| Message ID | 1555396913-26870-1-git-send-email-ophirmu@mellanox.com |
|---|---|
| State | Accepted |
| Delegated to: | Ian Stokes |
| Headers | show |
| Series | [ovs-dev,dpdk-latest,v1] dpdk: Update by new color definitions. | expand |
On 4/16/2019 7:41 AM, Ophir Munk wrote: > Follwoing dpdk new color definitions (see [1]) 'e_RTE_METER_GREEN' > was replaced with 'RTE_COLOR_GREEN'. > > [1] > Commit c1656328dbc2: ("meter: replace color definitions") > > Signed-off-by: Ophir Munk <ophirmu@mellanox.com> Thanks for this Ophir, this fixes compilation with DPDK master so I've pushed this to dpdk-latest with a slight modification to the subject line (dpdk: -> netdev-dpdk). Thanks Ian
Thanks Ian for accepting this. Please note a review comment from Asaf: Typo in commit message: Follwoing --> Following Regards, Ophir > -----Original Message----- > From: Ian Stokes <ian.stokes@intel.com> > Sent: Tuesday, April 16, 2019 4:00 PM > To: Ophir Munk <ophirmu@mellanox.com>; ovs-dev@openvswitch.org > Cc: Olga Shern <olgas@mellanox.com>; Kevin Traynor > <ktraynor@redhat.com>; Ilya Maximets <i.maximets@samsung.com>; Asaf > Penso <asafp@mellanox.com>; Aaron Conole <aconole@redhat.com>; > Jeremy Plsek <jplsek@iol.unh.edu> > Subject: Re: [dpdk-latest PATCH v1] dpdk: Update by new color definitions. > > On 4/16/2019 7:41 AM, Ophir Munk wrote: > > Follwoing dpdk new color definitions (see [1]) 'e_RTE_METER_GREEN' > > was replaced with 'RTE_COLOR_GREEN'. > > > > [1] > > Commit c1656328dbc2: ("meter: replace color definitions") > > > > Signed-off-by: Ophir Munk <ophirmu@mellanox.com> > > Thanks for this Ophir, this fixes compilation with DPDK master so I've pushed > this to dpdk-latest with a slight modification to the subject line (dpdk: -> > netdev-dpdk). > > Thanks > Ian
On 4/16/2019 9:46 PM, Ophir Munk wrote: > Thanks Ian for accepting this. Please note a review comment from Asaf: > Typo in commit message: Follwoing --> Following > No problem, I had fixed that upon commit also. Thanks Ian > Regards, > Ophir > >> -----Original Message----- >> From: Ian Stokes <ian.stokes@intel.com> >> Sent: Tuesday, April 16, 2019 4:00 PM >> To: Ophir Munk <ophirmu@mellanox.com>; ovs-dev@openvswitch.org >> Cc: Olga Shern <olgas@mellanox.com>; Kevin Traynor >> <ktraynor@redhat.com>; Ilya Maximets <i.maximets@samsung.com>; Asaf >> Penso <asafp@mellanox.com>; Aaron Conole <aconole@redhat.com>; >> Jeremy Plsek <jplsek@iol.unh.edu> >> Subject: Re: [dpdk-latest PATCH v1] dpdk: Update by new color definitions. >> >> On 4/16/2019 7:41 AM, Ophir Munk wrote: >>> Follwoing dpdk new color definitions (see [1]) 'e_RTE_METER_GREEN' >>> was replaced with 'RTE_COLOR_GREEN'. >>> >>> [1] >>> Commit c1656328dbc2: ("meter: replace color definitions") >>> >>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com> >> >> Thanks for this Ophir, this fixes compilation with DPDK master so I've pushed >> this to dpdk-latest with a slight modification to the subject line (dpdk: -> >> netdev-dpdk). >> >> Thanks >> Ian
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 47153dc..f129b99 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2031,7 +2031,7 @@ netdev_dpdk_policer_pkt_handle(struct rte_meter_srtcm *meter, uint32_t pkt_len = rte_pktmbuf_pkt_len(pkt) - sizeof(struct ether_hdr); return rte_meter_srtcm_color_blind_check(meter, profile, time, pkt_len) == - e_RTE_METER_GREEN; + RTE_COLOR_GREEN; } static int
Follwoing dpdk new color definitions (see [1]) 'e_RTE_METER_GREEN' was replaced with 'RTE_COLOR_GREEN'. [1] Commit c1656328dbc2: ("meter: replace color definitions") Signed-off-by: Ophir Munk <ophirmu@mellanox.com> --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)