From patchwork Thu Apr 11 07:29:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1083732 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="d/jz+TuE"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44ft4S517Cz9s0W for ; Thu, 11 Apr 2019 17:31:20 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id ED818229A; Thu, 11 Apr 2019 07:30:16 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CD1ED1C8E for ; Thu, 11 Apr 2019 07:30:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8402885B for ; Thu, 11 Apr 2019 07:30:01 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190411073000euoutp0152dbdc4d246f9663573517feab61d187~UWvnBTnCG1641316413euoutp018 for ; Thu, 11 Apr 2019 07:30:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190411073000euoutp0152dbdc4d246f9663573517feab61d187~UWvnBTnCG1641316413euoutp018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1554967800; bh=khgychI/AdXbMCQ3HaG44na0oqAOzZxBhABlxoQs8C8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d/jz+TuEWfsGk7puURVD4DbE2acKBUT6SoreUn1zDD8z67VJzwoWJXoPpzCi4bVax XwfpmCOm20+tMoAywlaaYe7JVl8D+uz+mEYxo+17MOqjDhMZOpDtrXcqgczXzNEee4 nXE5X4bqmWDExETu8z4GzS+v5soPRiT4N/Wr4aqw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190411072959eucas1p1374ea86773cfb2f16ac4daf8e184f104~UWvmnUPlw1848018480eucas1p1x; Thu, 11 Apr 2019 07:29:59 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 0C.CD.04325.7FCEEAC5; Thu, 11 Apr 2019 08:29:59 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190411072958eucas1p112a2c32d0f75df47f8f01702fb21e325~UWvl7VUby0860908609eucas1p1P; Thu, 11 Apr 2019 07:29:58 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190411072958eusmtrp229ee878aaafa527b2e8e96740246c7eb~UWvltUpRL0830608306eusmtrp2M; Thu, 11 Apr 2019 07:29:58 +0000 (GMT) X-AuditID: cbfec7f5-b75ff700000010e5-f4-5caeecf72d69 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 59.AF.04146.6FCEEAC5; Thu, 11 Apr 2019 08:29:58 +0100 (BST) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190411072958eusmtip2f254ebf33de4466ca428847c1636e440~UWvlNGk1A1041110411eusmtip2S; Thu, 11 Apr 2019 07:29:58 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ian Stokes Date: Thu, 11 Apr 2019 10:29:43 +0300 Message-Id: <20190411072943.29566-3-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190411072943.29566-1-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0hTYRju29nZjsPJcVq+qWCO/OEoLfLHUFEjgxEY/otKyqOevE5lU8sM EjM1mxcyHHbTMGdN0lYmaiI5Qy1LC5xNIVTK+3R4nytdO51Jfz6e28vz8vIRmKgY9ySS07No RTqVJuYJuG1928NHt0zNMcfGNQekVtMkX7pQlY+ki7dXkbS1ugqXjhRv86W6qS+49PHqLIrg y+q75jmyGXWv/RmzIdnsqIorM3cbeLLyVi2S2W4Z8Gj+BUFoAp2WnEMrAsNiBUlFuiaUuQnX tro6UT4qFZUiJwLIIChr0GClSECIyOcIpn5ZuSxZR/D2RQPOkjUEfQU/uHsjG0tFiDUa7cbK Fo8lFgSjlRM4k+KRR+BT0wfEYHcyDKq1BRwmhJE6BJvf7/MYw408A+N3tXaDILikH9ypCGZk IRkC9ZNjiG3zgaZX7zEGO5GhUFVo+VcGpI0H3Y/GcTYUCeUNOxwWu8FCfyufxd5g66h16Ddh onAescMlCNT6XYcRDq2LQ3xmCYz0h5bOQFY+CbXvVDxGBtIFjEuujIzZ4b02NcbKQigpctzx MPzuacRY7Aljy2uODWQwN9fhuG8FgmmjBq9EPg/+l9UhpEUedLZSnkgrT6TTVwOUlFyZnZ4Y EJ8hf43s32Nwt3+jHXX/idMjkkBiZ6F0+2WMCKdylLlyPQICE7sLzx5qjhEJE6jc67Qi47Ii O41W6pEXwRV7CPP2TV4UkYlUFp1K05m0Ys/lEE6e+eiS73lznmFkuBubUmnqvdsjDYWpNZaP AzUuxviUr30Hp7v6V5LNbg/x8Gec6KdeFu36/tMzdVfe+Lmeoyv842J1ccGDQkIy1JJSd8E7 yVr20+Qf7LqjDpLrnKMqqZ6Ib3PmGwPG5QBJWckTla9vb781c3FoRnIqUR8SFvXZtC7mKpOo 4xJMoaT+ApWRktQaAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xe7rf3qyLMZixVN3i15sH7BavJjcw Wrxu/cRosWXaZFaLK+0/2S02PjzLajH303NGB3aPxXteMnk8m34YSNz8z+jx/FoPi8f7fVfZ PPq2rGL0+N98lTWAPUrPpii/tCRVISO/uMRWKdrQwkjP0NJCz8jEUs/Q2DzWyshUSd/OJiU1 J7MstUjfLkEvo23jasaCbxIV3/fsYmxg7BLqYuTkkBAwkfj6to0RxBYSWMoocfYtI0RcSuLH rwusELawxJ9rXWxdjFxANd8YJa5cOAtWxCagI3Fq9REwW0TAQWLz3cWsIEXMAlsZJb5vuw7W LSzgJXGrexVTFyMHB4uAqkRnvxVImFfAWmLxg5tQy+QlVm84wAxicwrYSExu+cEGcZC1xKrX CxknMPItYGRYxSiSWlqcm55bbKhXnJhbXJqXrpecn7uJERjI24793LyD8dLG4EOMAhyMSjy8 E36vjRFiTSwrrsw9xCjBwawkwuunsC5GiDclsbIqtSg/vqg0J7X4EKMp0E0TmaVEk/OBUZZX Em9oamhuYWlobmxubGahJM573qAySkggPbEkNTs1tSC1CKaPiYNTqoEx4N2fykdBfz5fyxZ5 qj4vZ9+Uo+zrnBO1Xms/XPeMzWi1aW/MhbfLnitzT9OZfmGS3tvL+txtqZ/sYwONdnCsL/1U 3ukddvGr85bQTx/2f2SbxH1L0f5PyIe7HC4Ok7fZVB4VVcnfLPPza518hHTE+pN/tl0//mrl SsEYkbhNCrP9S4QKdHv2K7EUZyQaajEXFScCAIKCyP16AgAA X-CMS-MailID: 20190411072958eucas1p112a2c32d0f75df47f8f01702fb21e325 X-Msg-Generator: CA X-RootMTR: 20190411072958eucas1p112a2c32d0f75df47f8f01702fb21e325 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190411072958eucas1p112a2c32d0f75df47f8f01702fb21e325 References: <20190411072943.29566-1-i.maximets@samsung.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Flavio Leitner , Eli Britstein Subject: [ovs-dev] [PATCH v2 2/2] acinclude: Use AC_SEARCH_LIBS for linking with dl. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org DPDK uses dlopen to load plugins and we need to search for library containing this function. But we should not do this in a loop because 'AC_SEARCH_LIBS' could do this for us. Also, 'AC_SEARCH_LIBS' prints user-visible messages that are useful for debuging. Also added the new 'checking' message and code normalized to be more readable. With this change we'll have following additional messages: checking for library containing dlopen... -ldl checking whether linking with dpdk works... yes Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- acinclude.m4 | 50 +++++++++++++++++++++----------------------------- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 22fbf3f40..0dbd3bedc 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -301,36 +301,28 @@ AC_DEFUN([OVS_CHECK_DPDK], [ ], [[#include ]]) ], [], [[#include ]]) - # On some systems we have to add -ldl to link with dpdk - # - # This code, at first, tries to link without -ldl (""), - # then adds it and tries again. - # Before each attempt the search cache must be unset, - # otherwise autoconf will stick with the old result + # DPDK uses dlopen to load plugins. + OVS_FIND_DEPENDENCY([dlopen], [dl], [libdl]) + + AC_MSG_CHECKING([whether linking with dpdk works]) + LIBS="$DPDK_LIB $LIBS" + AC_LINK_IFELSE( + [AC_LANG_PROGRAM([#include + #include ], + [int rte_argc; char ** rte_argv; + rte_eal_init(rte_argc, rte_argv);])], + [AC_MSG_RESULT([yes]) + DPDKLIB_FOUND=true], + [AC_MSG_RESULT([no]) + if test "$DPDK_AUTO_DISCOVER" = "true"; then + AC_MSG_ERROR(m4_normalize([ + Could not find DPDK library in default search path, Use --with-dpdk + to specify the DPDK library installed in non-standard location])) + else + AC_MSG_ERROR([Could not find DPDK libraries in $DPDK_LIB_DIR]) + fi + ]) - DPDKLIB_FOUND=false - save_LIBS=$LIBS - for extras in "" "-ldl"; do - LIBS="$DPDK_LIB $extras $save_LIBS" - AC_LINK_IFELSE( - [AC_LANG_PROGRAM([#include - #include ], - [int rte_argc; char ** rte_argv; - rte_eal_init(rte_argc, rte_argv);])], - [DPDKLIB_FOUND=true]) - if $DPDKLIB_FOUND; then - break - fi - done - - # If linking unsuccessful - if test "$DPDKLIB_FOUND" = "false" ; then - if $DPDK_AUTO_DISCOVER; then - AC_MSG_ERROR([Could not find DPDK library in default search path, Use --with-dpdk to specify the DPDK library installed in non-standard location]) - else - AC_MSG_ERROR([Could not find DPDK libraries in $DPDK_LIB_DIR]) - fi - fi CFLAGS="$ovs_save_CFLAGS" LDFLAGS="$ovs_save_LDFLAGS" if test "$DPDK_AUTO_DISCOVER" = "false"; then