[ovs-dev,2/5] extract-ofp-fields: Improve error message.
diff mbox series

Message ID 20190408182206.15688-2-blp@ovn.org
State Accepted
Headers show
Series
  • [ovs-dev,1/5] compiler: Disable BUILD_MESSAGE() when processing with sparse.
Related show

Commit Message

Ben Pfaff April 8, 2019, 6:22 p.m. UTC
Without this change, it's not obvious what needs to be edited.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 build-aux/extract-ofp-fields | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Numan Siddique April 9, 2019, 5:43 p.m. UTC | #1
On Mon, Apr 8, 2019 at 11:53 PM Ben Pfaff <blp@ovn.org> wrote:

> Without this change, it's not obvious what needs to be edited.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>

Acked-by: Numan Siddique <nusiddiq@redhat.com>


> ---
>  build-aux/extract-ofp-fields | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/build-aux/extract-ofp-fields b/build-aux/extract-ofp-fields
> index e159a1df66e2..7a4e8e170171 100755
> --- a/build-aux/extract-ofp-fields
> +++ b/build-aux/extract-ofp-fields
> @@ -757,7 +757,9 @@ ovs\-fields \- protocol header fields in OpenFlow and
> Open vSwitch
>
>      for f in fields:
>          if "used" not in f:
> -            fatal("%s: field not documented" % f["mff"])
> +            fatal("%s: field not documented "
> +                  "(please add documentation in lib/meta-flow.xml)"
> +                  % f["mff"])
>      if n_errors:
>          sys.exit(1)
>
> --
> 2.20.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

Patch
diff mbox series

diff --git a/build-aux/extract-ofp-fields b/build-aux/extract-ofp-fields
index e159a1df66e2..7a4e8e170171 100755
--- a/build-aux/extract-ofp-fields
+++ b/build-aux/extract-ofp-fields
@@ -757,7 +757,9 @@  ovs\-fields \- protocol header fields in OpenFlow and Open vSwitch
 
     for f in fields:
         if "used" not in f:
-            fatal("%s: field not documented" % f["mff"])
+            fatal("%s: field not documented "
+                  "(please add documentation in lib/meta-flow.xml)"
+                  % f["mff"])
     if n_errors:
         sys.exit(1)