[ovs-dev] rhel: Include all header files in the Fedora's devel package
diff mbox series

Message ID 20190401162631.2609-1-aatteka@ovn.org
State New
Headers show
Series
  • [ovs-dev] rhel: Include all header files in the Fedora's devel package
Related show

Commit Message

Ansis Atteka April 1, 2019, 4:26 p.m. UTC
From: Ansis Atteka <aatteka@vmware.com>

While the header files added by this patch into Fedora's devel
rpm package can be considered private, the other devel packages
for RHEL/CentOS and Debian/Ubuntu distros include them.

So this patch simply makes the Fedora devel package consistent with
the other devel packages.

Signed-off-by: Ansis Atteka <aatteka@ovn.org>
---
 rhel/openvswitch-fedora.spec.in | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Gregory Rose April 1, 2019, 4:42 p.m. UTC | #1
On 4/1/2019 9:26 AM, Ansis Atteka wrote:
> From: Ansis Atteka <aatteka@vmware.com>
>
> While the header files added by this patch into Fedora's devel
> rpm package can be considered private, the other devel packages
> for RHEL/CentOS and Debian/Ubuntu distros include them.
>
> So this patch simply makes the Fedora devel package consistent with
> the other devel packages.
>
> Signed-off-by: Ansis Atteka <aatteka@ovn.org>
> ---
>   rhel/openvswitch-fedora.spec.in | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index 198a48de7..c1cd3f4c6 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -224,6 +224,20 @@ make install DESTDIR=$RPM_BUILD_ROOT
>   install -d -m 0755 $RPM_BUILD_ROOT%{_rundir}/openvswitch
>   install -d -m 0750 $RPM_BUILD_ROOT%{_localstatedir}/log/openvswitch
>   install -d -m 0755 $RPM_BUILD_ROOT%{_sysconfdir}/openvswitch
> +copy_headers() {
> +    src=$1
> +    dst=$RPM_BUILD_ROOT/$2
> +    install -d -m 0755 $dst
> +    install -m 0644 $src/*.h $dst
> +}
> +copy_headers include %{_includedir}/openvswitch
> +copy_headers include/openflow %{_includedir}/openvswitch/openflow
> +copy_headers include/openvswitch %{_includedir}/openvswitch/openvswitch
> +copy_headers include/sparse %{_includedir}/openvswitch/sparse
> +copy_headers include/sparse/arpa %{_includedir}/openvswitch/sparse/arpa
> +copy_headers include/sparse/netinet %{_includedir}/openvswitch/sparse/netinet
> +copy_headers include/sparse/sys %{_includedir}/openvswitch/sparse/sys
> +copy_headers lib %{_includedir}/openvswitch/lib
>   
>   %if %{with dpdk}
>   install -p -D -m 0644 rhel/usr_lib_udev_rules.d_91-vfio.rules \
LGTM

Reviewed-by: Greg Rose <gvrose8192@gmail.com>
0-day Robot April 1, 2019, 5 p.m. UTC | #2
Bleep bloop.  Greetings Ansis Atteka, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Ansis Atteka <aatteka@vmware.com> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Ansis Atteka <aatteka@ovn.org>
Lines checked: 47, Warnings: 1, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
Ben Pfaff April 16, 2019, 7:58 p.m. UTC | #3
On Mon, Apr 01, 2019 at 09:26:31AM -0700, Ansis Atteka wrote:
> From: Ansis Atteka <aatteka@vmware.com>
> 
> While the header files added by this patch into Fedora's devel
> rpm package can be considered private, the other devel packages
> for RHEL/CentOS and Debian/Ubuntu distros include them.
> 
> So this patch simply makes the Fedora devel package consistent with
> the other devel packages.
> 
> Signed-off-by: Ansis Atteka <aatteka@ovn.org>

I support consistency here.  I didn't test the patch.
Aaron Conole April 17, 2019, 3:49 p.m. UTC | #4
Ben Pfaff <blp@ovn.org> writes:

> On Mon, Apr 01, 2019 at 09:26:31AM -0700, Ansis Atteka wrote:
>> From: Ansis Atteka <aatteka@vmware.com>
>> 
>> While the header files added by this patch into Fedora's devel
>> rpm package can be considered private, the other devel packages
>> for RHEL/CentOS and Debian/Ubuntu distros include them.
>> 
>> So this patch simply makes the Fedora devel package consistent with
>> the other devel packages.
>> 
>> Signed-off-by: Ansis Atteka <aatteka@ovn.org>
>
> I support consistency here.  I didn't test the patch.

In case it hasn't been applied yet:

Acked-by: Aaron Conole <aconole@redhat.com>


Actually, I think it helps with the ovn / ovs split.
Ansis Atteka April 17, 2019, 6:43 p.m. UTC | #5
On Wed, 17 Apr 2019 at 08:49, Aaron Conole <aconole@redhat.com> wrote:
>
> Ben Pfaff <blp@ovn.org> writes:
>
> > On Mon, Apr 01, 2019 at 09:26:31AM -0700, Ansis Atteka wrote:
> >> From: Ansis Atteka <aatteka@vmware.com>
> >>
> >> While the header files added by this patch into Fedora's devel
> >> rpm package can be considered private, the other devel packages
> >> for RHEL/CentOS and Debian/Ubuntu distros include them.
> >>
> >> So this patch simply makes the Fedora devel package consistent with
> >> the other devel packages.
> >>
> >> Signed-off-by: Ansis Atteka <aatteka@ovn.org>
> >
> > I support consistency here.  I didn't test the patch.
>
> In case it hasn't been applied yet:
>
> Acked-by: Aaron Conole <aconole@redhat.com>
>
>
> Actually, I think it helps with the ovn / ovs split.

Thanks for reviews. I already pushed this.

Patch
diff mbox series

diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 198a48de7..c1cd3f4c6 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -224,6 +224,20 @@  make install DESTDIR=$RPM_BUILD_ROOT
 install -d -m 0755 $RPM_BUILD_ROOT%{_rundir}/openvswitch
 install -d -m 0750 $RPM_BUILD_ROOT%{_localstatedir}/log/openvswitch
 install -d -m 0755 $RPM_BUILD_ROOT%{_sysconfdir}/openvswitch
+copy_headers() {
+    src=$1
+    dst=$RPM_BUILD_ROOT/$2
+    install -d -m 0755 $dst
+    install -m 0644 $src/*.h $dst
+}
+copy_headers include %{_includedir}/openvswitch
+copy_headers include/openflow %{_includedir}/openvswitch/openflow
+copy_headers include/openvswitch %{_includedir}/openvswitch/openvswitch
+copy_headers include/sparse %{_includedir}/openvswitch/sparse
+copy_headers include/sparse/arpa %{_includedir}/openvswitch/sparse/arpa
+copy_headers include/sparse/netinet %{_includedir}/openvswitch/sparse/netinet
+copy_headers include/sparse/sys %{_includedir}/openvswitch/sparse/sys
+copy_headers lib %{_includedir}/openvswitch/lib
 
 %if %{with dpdk}
 install -p -D -m 0644 rhel/usr_lib_udev_rules.d_91-vfio.rules \