| Message ID | 20190322191436.6268-2-urjaman@gmail.com |
|---|---|
| State | Accepted |
| Commit | 63402831e0b68ded49c054989fffdfd88b98953b |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | Veyron Speedy / ASUS C201 fixes | expand |
On Fri, 22 Mar 2019 at 13:15, Urja Rannikko <urjaman@gmail.com> wrote: > > This fixes RK3288 SPL hanging or hitting this assert: > drivers/core/ofnode.c:183: ofnode_first_subnode: Assertion `ofnode_valid(node)' failed. > > Signed-off-by: Urja Rannikko <urjaman@gmail.com> > --- > drivers/pinctrl/pinctrl-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
> This fixes RK3288 SPL hanging or hitting this assert: > drivers/core/ofnode.c:183: ofnode_first_subnode: Assertion `ofnode_valid(node)' failed. > > Signed-off-by: Urja Rannikko <urjaman@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > drivers/pinctrl/pinctrl-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> This fixes RK3288 SPL hanging or hitting this assert: > drivers/core/ofnode.c:183: ofnode_first_subnode: Assertion `ofnode_valid(node)' failed. > > Signed-off-by: Urja Rannikko <urjaman@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > drivers/pinctrl/pinctrl-uclass.c | 3 +++ > 1 file changed, 3 insertions(+) > Applied to u-boot-rockchip, thanks!
diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index 0e3260afd1..bda951b07f 100644 --- a/drivers/pinctrl/pinctrl-uclass.c +++ b/drivers/pinctrl/pinctrl-uclass.c @@ -138,6 +138,9 @@ static int pinconfig_post_bind(struct udevice *dev) ofnode node; int ret; + if (!dev_of_valid(dev)) + return 0; + dev_for_each_subnode(node, dev) { if (pre_reloc_only && !ofnode_pre_reloc(node))
This fixes RK3288 SPL hanging or hitting this assert: drivers/core/ofnode.c:183: ofnode_first_subnode: Assertion `ofnode_valid(node)' failed. Signed-off-by: Urja Rannikko <urjaman@gmail.com> --- drivers/pinctrl/pinctrl-uclass.c | 3 +++ 1 file changed, 3 insertions(+)