| Message ID | 20190320070640.102721-1-posk@google.com |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT | expand |
On Wed, Mar 20, 2019 at 12:06:40AM -0700, Peter Oskolkov wrote: > This helper is useful if a bpf tc filter sets skb->tstamp. > > Signed-off-by: Peter Oskolkov <posk@google.com> > --- > net/core/filter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 647c63a7b25b..c6d016d9c4b8 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -5719,6 +5719,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) > return &bpf_tcp_sock_proto; > case BPF_FUNC_get_listener_sock: > return &bpf_get_listener_sock_proto; > + case BPF_FUNC_skb_ecn_set_ce: > + return &bpf_skb_ecn_set_ce_proto; makes sense, but I would like to see a selftest that it was tested properly.
diff --git a/net/core/filter.c b/net/core/filter.c index 647c63a7b25b..c6d016d9c4b8 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -5719,6 +5719,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) return &bpf_tcp_sock_proto; case BPF_FUNC_get_listener_sock: return &bpf_get_listener_sock_proto; + case BPF_FUNC_skb_ecn_set_ce: + return &bpf_skb_ecn_set_ce_proto; #endif default: return bpf_base_func_proto(func_id);
This helper is useful if a bpf tc filter sets skb->tstamp. Signed-off-by: Peter Oskolkov <posk@google.com> --- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+)