[U-Boot] ARM: HYP/non-sec: Don't enable ARMV7_LPAE for old sunxi kernels
diff mbox series

Message ID 20190319054007.2268-1-net147@gmail.com
State Changes Requested
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series
  • [U-Boot] ARM: HYP/non-sec: Don't enable ARMV7_LPAE for old sunxi kernels
Related show

Commit Message

Jonathan Liu March 19, 2019, 5:40 a.m. UTC
Old sunxi kernels fail to boot with ARMV7_LPAE enabled.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 arch/arm/cpu/armv7/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jagan Teki March 21, 2019, 5:05 p.m. UTC | #1
On Tue, Mar 19, 2019 at 11:09 AM Jonathan Liu <net147@gmail.com> wrote:
>
> Old sunxi kernels fail to boot with ARMV7_LPAE enabled.

Any idea why? I don't have relevant stuff with to test this.
Jonathan Liu March 21, 2019, 9:01 p.m. UTC | #2
Hi Jagan,

On Fri., 22 Mar. 2019 at 4:05 am, Jagan Teki <jagan@amarulasolutions.com>
wrote:

> On Tue, Mar 19, 2019 at 11:09 AM Jonathan Liu <net147@gmail.com> wrote:
> >
> > Old sunxi kernels fail to boot with ARMV7_LPAE enabled.
>
> Any idea why? I don't have relevant stuff with to test this.
>
I don't know why. It failed to boot linux-sunxi 3.4.104 kernel on A20
OLinuXino-MICRO after updating from 2018.07 to 2018.09-rc1 and would hang
at "Starting kernel...".

I bisected the issue to:
https://git.denx.de/?p=u-boot.git;a=commit;h=d32e86bde8a31a49cf4a9b233ad91ecdfc96ba2a

No problems booting mainline kernel.

Thanks.

Regards,
Jonathan
Jagan Teki April 12, 2019, 6:32 a.m. UTC | #3
On Fri, Mar 22, 2019 at 2:31 AM Jonathan Liu <net147@gmail.com> wrote:
>
> Hi Jagan,
>
> On Fri., 22 Mar. 2019 at 4:05 am, Jagan Teki <jagan@amarulasolutions.com> wrote:
>>
>> On Tue, Mar 19, 2019 at 11:09 AM Jonathan Liu <net147@gmail.com> wrote:
>> >
>> > Old sunxi kernels fail to boot with ARMV7_LPAE enabled.
>>
>> Any idea why? I don't have relevant stuff with to test this.
>
> I don't know why. It failed to boot linux-sunxi 3.4.104 kernel on A20 OLinuXino-MICRO after updating from 2018.07 to 2018.09-rc1 and would hang at "Starting kernel...".
>
> I bisected the issue to:
> https://git.denx.de/?p=u-boot.git;a=commit;h=d32e86bde8a31a49cf4a9b233ad91ecdfc96ba2a
>
> No problems booting mainline kernel.

Can you update full details of bug on the commit message.
Mark Kettenis April 12, 2019, 1:03 p.m. UTC | #4
> From: Jagan Teki <jagan@amarulasolutions.com>
> Date: Fri, 12 Apr 2019 12:02:06 +0530
> 
> On Fri, Mar 22, 2019 at 2:31 AM Jonathan Liu <net147@gmail.com> wrote:
> >
> > Hi Jagan,
> >
> > On Fri., 22 Mar. 2019 at 4:05 am, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >>
> >> On Tue, Mar 19, 2019 at 11:09 AM Jonathan Liu <net147@gmail.com> wrote:
> >> >
> >> > Old sunxi kernels fail to boot with ARMV7_LPAE enabled.
> >>
> >> Any idea why? I don't have relevant stuff with to test this.
> >
> > I don't know why. It failed to boot linux-sunxi 3.4.104 kernel on A20 OLinuXino-MICRO after updating from 2018.07 to 2018.09-rc1 and would hang at "Starting kernel...".
> >
> > I bisected the issue to:
> > https://git.denx.de/?p=u-boot.git;a=commit;h=d32e86bde8a31a49cf4a9b233ad91ecdfc96ba2a
> >
> > No problems booting mainline kernel.
> 
> Can you update full details of bug on the commit message.

Technically I think the right thing to do would be disabling
ARMV7_VIRT as my understanding is that booting into HYP mode doesn't
work without LPAE support.
U.Mutlu April 12, 2019, 8:56 p.m. UTC | #5
Mark Kettenis wrote on 04/12/2019 03:03 PM:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>> Date: Fri, 12 Apr 2019 12:02:06 +0530
>>
>> On Fri, Mar 22, 2019 at 2:31 AM Jonathan Liu <net147@gmail.com> wrote:
>>>
>>> Hi Jagan,
>>>
>>> On Fri., 22 Mar. 2019 at 4:05 am, Jagan Teki <jagan@amarulasolutions.com> wrote:
>>>>
>>>> On Tue, Mar 19, 2019 at 11:09 AM Jonathan Liu <net147@gmail.com> wrote:
>>>>>
>>>>> Old sunxi kernels fail to boot with ARMV7_LPAE enabled.
>>>>
>>>> Any idea why? I don't have relevant stuff with to test this.
>>>
>>> I don't know why. It failed to boot linux-sunxi 3.4.104 kernel on A20 OLinuXino-MICRO after updating from 2018.07 to 2018.09-rc1 and would hang at "Starting kernel...".
>>>
>>> I bisected the issue to:
>>> https://git.denx.de/?p=u-boot.git;a=commit;h=d32e86bde8a31a49cf4a9b233ad91ecdfc96ba2a
>>>
>>> No problems booting mainline kernel.
>>
>> Can you update full details of bug on the commit message.
>
> Technically I think the right thing to do would be disabling
> ARMV7_VIRT as my understanding is that booting into HYP mode doesn't
> work without LPAE support.

Some days ago I tried to disable HYP mode for SVC mode.
But with SVC the PSCI is not loading (u-boot bug?), and without PSCI
only the 1st core of the CPU gets used. I had documented the case here:
https://lists.denx.de/pipermail/u-boot/2019-April/364192.html

Patch
diff mbox series

diff --git a/arch/arm/cpu/armv7/Kconfig b/arch/arm/cpu/armv7/Kconfig
index 73d57a2aae..cdb7e402b4 100644
--- a/arch/arm/cpu/armv7/Kconfig
+++ b/arch/arm/cpu/armv7/Kconfig
@@ -53,7 +53,7 @@  config ARMV7_PSCI_NR_CPUS
 config ARMV7_LPAE
 	bool "Use LPAE page table format" if EXPERT
 	depends on CPU_V7A
-	default y if ARMV7_VIRT
+	default y if ARMV7_VIRT && !OLD_SUNXI_KERNEL_COMPAT
 	---help---
 	Say Y here to use the long descriptor page table format. This is
 	required if U-Boot runs in HYP mode.