Message ID | 155248884129.893204.2293309859485638162.stgit@bahia.lan |
---|---|
State | New |
Headers | show |
Series | [1/2] ppc/pnv: Use local_err variable in pnv_chip_power9_intc_create() | expand |
On 3/13/19 3:54 PM, Greg Kurz wrote: > Detected by Coverity: CID 1399702 > > Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > hw/ppc/pnv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index 8be4d4cbf785..dfb4ea5742c1 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -755,7 +755,7 @@ static void pnv_chip_power9_intc_create(PnvChip *chip, PowerPCCPU *cpu, > * controller object is initialized afterwards. Hopefully, it's > * only used at runtime. > */ > - obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), errp); > + obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), &local_err); > if (local_err) { > error_propagate(errp, local_err); > return; >
On Wed, Mar 13, 2019 at 03:54:01PM +0100, Greg Kurz wrote: > Detected by Coverity: CID 1399702 Series applied to ppc-for-4.0, thanks. > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > hw/ppc/pnv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index 8be4d4cbf785..dfb4ea5742c1 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -755,7 +755,7 @@ static void pnv_chip_power9_intc_create(PnvChip *chip, PowerPCCPU *cpu, > * controller object is initialized afterwards. Hopefully, it's > * only used at runtime. > */ > - obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), errp); > + obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), &local_err); > if (local_err) { > error_propagate(errp, local_err); > return; >
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 8be4d4cbf785..dfb4ea5742c1 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -755,7 +755,7 @@ static void pnv_chip_power9_intc_create(PnvChip *chip, PowerPCCPU *cpu, * controller object is initialized afterwards. Hopefully, it's * only used at runtime. */ - obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), errp); + obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), &local_err); if (local_err) { error_propagate(errp, local_err); return;
Detected by Coverity: CID 1399702 Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/ppc/pnv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)