From patchwork Fri Mar 8 07:32:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li,Rongqing via dev" X-Patchwork-Id: 1053389 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=openvswitch.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=aliyun.com header.i=@aliyun.com header.b="qYxTn9TA"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Fzjk5kwyz9s7T for ; Fri, 8 Mar 2019 18:32:41 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id C8991C030; Fri, 8 Mar 2019 07:32:37 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 90F1ECB0 for ; Fri, 8 Mar 2019 07:32:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from out30-38.freemail.mail.aliyun.com (out30-38.freemail.mail.aliyun.com [115.124.30.38]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2489E12E for ; Fri, 8 Mar 2019 07:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aliyun.com; s=s1024; t=1552030352; h=Date:From:Message-ID:Subject:MIME-Version:Content-Type; bh=/sCPI2fZ+/vCZjMmEBHvYs+S7VdbTk3H8rNuNR4cbrg=; b=qYxTn9TA0cvhwAd2zHtWOh0nseBNgO4OoS/t9d8bkbfLXT2pYEjLo2CAsy63sAqwfH8OC6FzoFEYAb3tJ7LgBZd67KCVsMspFXDDsqv1M7XBsZn3U+gxvd4JEbG1onBCk+kq5pQdVDK7bpW1t3B/NF+VbSZyuqjJo9VV4BkWF3I= X-Alimail-AntiSpam: AC=CONTINUE; BC=0.09415799|-1; CH=green; DM=||false|; FP=0|0|0|0|0|-1|-1|-1; HT=e01f04452; MF=txfh2007@aliyun.com; NM=1; PH=DW; RN=1; RT=1; SR=0; TI=W4_5478978_v5_0AC264D5_1552023730825_o7001c445r; Received: from WS-web (txfh2007@aliyun.com[W4_5478978_v5_0AC264D5_1552023730825_o7001c445r]) by e01f04396.eu6 at Fri, 08 Mar 2019 15:32:29 +0800 Date: Fri, 08 Mar 2019 15:32:29 +0800 Cc: "ovs-dev" Message-ID: <3ee81795-5dbb-496a-a26b-eb8e142d381a.txfh2007@aliyun.com> X-Mailer: [Alimail-Mailagent][W4_5478978][v5][Edge] MIME-Version: 1.0 References: x-aliyun-mail-creator: W4_5478978_v5_RNTTW96aWxsYS81LjAgKFdpbmRvd3MgTlQgMTAuMDsgV2luNjQ7IHg2NCkgQXBwbGVXZWJLaXQvNTM3LjM2IChLSFRNTCwgbGlrZSBHZWNrbykgQ2hyb21lLzY0LjAuMzI4Mi4xNDAgU2FmYXJpLzUzNy4zNiBFZGdlLzE3LjE3MTM0LS In-Reply-To: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, MALFORMED_FREEMAIL, MISSING_HEADERS, RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] =?utf-8?q?=5BPATCH_v3=5D_ovs-tcpdump=3A_add_dump=5Fcmd_?= =?utf-8?q?checker_before_=5Fdoexec=28=29?= X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: txfh2007 via dev From: "Li,Rongqing via dev" Reply-To: txfh2007 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Hi Aaron: Thanks for your kinkdly suggession. I have tried your proposol and test in my repository. This is the new version. Add dump_cmd executable checker in ovs-tcpdump Signed-off-by: Liu Chang diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index 269c252..911c608 100755 --- a/utilities/ovs-tcpdump.in +++ b/utilities/ovs-tcpdump.in @@ -371,6 +371,9 @@ def argv_tuples(lst): except StopIteration: pass +def py_which(executable): + return any(os.access(os.path.join(path,executable),os.X_OK) + for path in os.environ["PATH"].split(os.pathsep)) def main(): db_sock = 'unix:@RUNDIR@/db.sock' @@ -416,6 +419,10 @@ def main(): print("Error: must at least specify an interface with '-i' option") sys.exit(1) + if not py_which(dump_cmd): + print("Error: unable to execute '%s' (check PATH)"%dump_cmd) + sys.exit(1) + if '-l' not in tcpdargs: tcpdargs.insert(0, '-l')