From patchwork Wed Mar 6 04:35:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wenxu X-Patchwork-Id: 1052118 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=ucloud.cn Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Dh1X2HT5z9ryj for ; Wed, 6 Mar 2019 15:41:50 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 38199993D; Wed, 6 Mar 2019 04:41:47 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C0DE9993C for ; Wed, 6 Mar 2019 04:41:45 +0000 (UTC) X-Greylist: delayed 00:05:33 by SQLgrey-1.7.6 Received: from m97188.mail.qiye.163.com (m97188.mail.qiye.163.com [220.181.97.188]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 5C5BE3F7 for ; Wed, 6 Mar 2019 04:41:44 +0000 (UTC) Received: from 10.19.61.167master (unknown [123.59.132.129]) by m97188.mail.qiye.163.com (Hmail) with ESMTPA id EFC87968EEF for ; Wed, 6 Mar 2019 12:36:08 +0800 (CST) From: wenxu@ucloud.cn To: dev@openvswitch.org Date: Wed, 6 Mar 2019 12:35:58 +0800 Message-Id: <1551846958-961-1-git-send-email-wenxu@ucloud.cn> X-Mailer: git-send-email 1.8.3.1 X-HM-Spam-Status: e1kIGBQJHllBS1VLV1koWUFJQjdXWS1ZQUlXWQkOFx4IWUFZMjUtOjcyP0 FLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Mj46Fhw5ITlPGQIvMDcPQzks VhgwCx1VSlVKTk5KQ09NQk1CS05MVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpJSFVO QlVKSElVSklCWVdZCAFZQUpJSEw3Bg++ X-HM-Tid: 0a6951498e9920bckuqyefc87968eef X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] dif-netlink: avoid offload the unsupported USERSPACE action X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: wenxu The hw do/t support USERSPACE action, it will lead many err logs as following "ERR|failed to offload flow: Operation not supported" Signed-off-by: wenxu --- lib/dpif-netlink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 00538e5..46fe022 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2036,6 +2036,9 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put) csum_on = tnl_cfg->csum; } netdev_close(outdev); + } else if (nl_attr_type(nla) == OVS_ACTION_ATTR_USERSPACE) { + err = EOPNOTSUPP; + goto out; } }