From patchwork Wed Mar 6 01:46:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Zhou X-Patchwork-Id: 1052101 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oh07v9j6"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44DfGx5GDSz9sDn for ; Wed, 6 Mar 2019 14:23:19 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 5CE36996D; Wed, 6 Mar 2019 03:23:14 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6411513E3 for ; Wed, 6 Mar 2019 01:46:46 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 20183180 for ; Wed, 6 Mar 2019 01:46:46 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id m2so6984259pgl.5 for ; Tue, 05 Mar 2019 17:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uCzqzgJVnaCDoreVYm+U1g8UyvwB+q9JtbqyMEH55gs=; b=oh07v9j60e0myzfKSiyI4zzKFqewACVmuDJoBOnF0RIkZy9XvkxBoasBYQLa7phw+f MquRERo5+uX9EDi9iNvOEYhjndO14w8i0IpaYZolm1HRwM4R1cYEgbLxjXb3Fflu1ZPN kGj6F8YxVD+DPVTDtnw7XNHAdcXNHu1k0rDBr+XeK1zpmuGiBqeO69ruUOkNI+ovGglL MifnspEPRF0aM/7FxYNwRhqUhIOEg7YxYss4rdZFNSc5O3iS4us/Ooz/N6XjojpZ0KT/ szI2HjUUyho86fruRaH4jpTUOsiCzUsWJ+wafBzBSmEz7M2s8hN7jxR+LGusuWI14JIV ZROg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uCzqzgJVnaCDoreVYm+U1g8UyvwB+q9JtbqyMEH55gs=; b=dsL1SyN9ak0momNiz5+Q4MmrEI67L+9C0ri6gdWIJh9Oyksz9x8zlQ8Ed5Zdl3qkcN n4MgJkvQ81A+agy0RcDsnoGfhKqbqakQkvcc9oHrxflidT51uobWTcH11lbVl8G/48dE Ck6qO2IkoNcP0R8yekSvJzT5OG/3t/t7Q/7tdfQSA6giTWKyMm4A63keyoWIUda/VrbC MrztqGhwBvLVlIpZOjt0Q7loHpgRLhbYx06gE0wdIHPkvJv08573cxoXRgHx745wea6i Mn5gLINrTM4PBVc/RmzGHnrYM7+RjaASpP11ak40A/wTHSd9V/7FqQ0HUe09JKOESBWW i05g== X-Gm-Message-State: APjAAAWJVzCA7dQiAzwiO9UDpAGUPktfZymf9WGG10QASOOoZ1/LmCQd JIAGh5QUb9bT3GQkv8cdpq/0vwWf X-Google-Smtp-Source: APXvYqyd7NkuEiiz+G1YtZ820Oq0DQd2xCjZZBFLuxDjFfRiTvG+vt0Tljxp26wZA+ch533waxDHIQ== X-Received: by 2002:a65:6483:: with SMTP id e3mr3999149pgv.273.1551836805398; Tue, 05 Mar 2019 17:46:45 -0800 (PST) Received: from localhost.localdomain.localdomain ([216.113.160.77]) by smtp.gmail.com with ESMTPSA id a184sm239455pge.68.2019.03.05.17.46.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 17:46:44 -0800 (PST) From: Han Zhou X-Google-Original-From: Han Zhou To: dev@openvswitch.org Date: Tue, 5 Mar 2019 17:46:36 -0800 Message-Id: <1551836796-65594-1-git-send-email-hzhou8@ebay.com> X-Mailer: git-send-email 2.1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ovsdb-idl: Fix memory leak of idl->remote. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Han Zhou Reported by Address Sanitizer. Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 8cfb201..554bf76 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -571,6 +571,9 @@ ovsdb_idl_destroy(struct ovsdb_idl *idl) ovsdb_idl_db_destroy(&idl->server); ovsdb_idl_db_destroy(&idl->data); json_destroy(idl->request_id); + if (idl->remote) { + free(idl->remote); + } free(idl); } }