From patchwork Tue Mar 5 16:28:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1051851 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="num+Gvmp"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44DN3N29FPz9s4V for ; Wed, 6 Mar 2019 03:42:24 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 50E0EFC9D; Tue, 5 Mar 2019 16:41:57 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 2D0DDFB9C for ; Tue, 5 Mar 2019 16:28:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B6B603F7 for ; Tue, 5 Mar 2019 16:28:38 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190305162837euoutp01bc47825160896dae1aba242ff894b55b~JHOUfJdil1772017720euoutp01f for ; Tue, 5 Mar 2019 16:28:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190305162837euoutp01bc47825160896dae1aba242ff894b55b~JHOUfJdil1772017720euoutp01f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1551803317; bh=p4bGcYvoQ3aJ+NCQhAXJo0YNrja0IIhTgpGDV2507W8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=num+Gvmp/FCrXcPz+8FwMSRGGKofh8vtfDhgTFr+m4BFTsK29v68AY/YoaX12/zv+ GHzOnz9Uylik66QZgJD5fohEH8cHCWM3yJwpqMLWNvb76Kt7i5k7xqaBDMpQZwIfQp PRmfVBTP8iLcu8GbBVd+zO+i4YQi3rIGi1Z137no= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190305162836eucas1p2664c5f174790a9fa00ae48dedd8a20aa~JHOUJIxwB3232732327eucas1p2O; Tue, 5 Mar 2019 16:28:36 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id BD.C2.04806.4B3AE7C5; Tue, 5 Mar 2019 16:28:36 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190305162835eucas1p19788f5a6e394ef5be459acc8d5176d09~JHOTdlZ7N0929409294eucas1p1Y; Tue, 5 Mar 2019 16:28:35 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190305162835eusmtrp1ad0b879468c27325db65ce91764a8893~JHOTPeVL01426714267eusmtrp1n; Tue, 5 Mar 2019 16:28:35 +0000 (GMT) X-AuditID: cbfec7f5-34dff700000012c6-fc-5c7ea3b4821a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 24.1B.04284.3B3AE7C5; Tue, 5 Mar 2019 16:28:35 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190305162835eusmtip14f051bff3be33f65020b850f16393ac8~JHOS0TZn00579005790eusmtip1f; Tue, 5 Mar 2019 16:28:35 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ian Stokes Date: Tue, 5 Mar 2019 19:28:26 +0300 Message-Id: <20190305162827.9059-2-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190305162827.9059-1-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsWy7djP87pbFtfFGCzqE7fYMm0yq8WV9p/s FhsfnmW1mPvpOaMDi8fiPS+ZPJ7d/M/o0bdlFaPH/+arrAEsUVw2Kak5mWWpRfp2CVwZh6aJ Fszjq9h5tJexgfEAVxcjJ4eEgInEk7lvmLsYuTiEBFYwShxbeZYVwvnCKPHt9WR2COczo8TC lwtZYVour+2BqlrOKDFtwgEWCOcHo0TbpF0sIFVsAjoSp1YfYQSxRQTsJKatamICsZkF/CW6 d60FiwsLuEgcefORDcRmEVCV6Pp8EyzOK2AlcfLHeaht8hKrNxxgBrE5Bawlrj3/A7ZZQuAM m8S9T7uYIYpcJPbM3cEEYQtLvDq+hR3ClpE4PbmHBcKul7jf8pIRormDUWL6oX9QDfYSW16f A2rgALpOU2L9Ln2IsKPE/eu7mEDCEgJ8EjfeCkLczycxadt0Zogwr0RHmxBEtYrE74PLoa6R krj57jM7RImHxPTHgSBhIYE+RolVb1wnMMrPQli1gJFxFaN4amlxbnpqsXFearlecWJucWle ul5yfu4mRmDsn/53/OsOxn1/kg4xCnAwKvHwTmitixFiTSwrrsw9xCjBwawkwvuvHSjEm5JY WZValB9fVJqTWnyIUZqDRUmct5rhQbSQQHpiSWp2ampBahFMlomDU6qB8WBGVZFX/Ikjyhvv /2vhb7NZW6Ry6fKFuFIn6+fNNYYB036Uz42dt+lz3tlpi9a78QVUr+S06IteM0VJaHs6w7O9 h3aLOcaoM8+5/aF1ct+apq2uvQo2n9cdWCN0ul/+uF6pr9KEG/+3Sqq8mPZnie81mW8qfdUv Qz8di701kUfo6OGzLoyrtZRYijMSDbWYi4oTATIGS2X5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t/xu7qbF9fFGHw8rGKxZdpkVosr7T/Z LTY+PMtqMffTc0YHFo/Fe14yeTy7+Z/Ro2/LKkaP/81XWQNYovRsivJLS1IVMvKLS2yVog0t jPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQyDk0TLZjHV7HzaC9jA+MBri5GTg4J AROJy2t7WLsYuTiEBJYySjRu3c4EkZCS+PHrAiuELSzx51oXG4gtJPCNUeLDiUQQm01AR+LU 6iOMILaIgIPE5ruLweqZBfwlZq7rBpsjLOAiceTNR7BeFgFVia7PN8HqeQWsJE7+OA81X15i 9YYDzCA2p4C1xLXnf1ghdllJHJ94gm0CI98CRoZVjCKppcW56bnFhnrFibnFpXnpesn5uZsY gaG47djPzTsYL20MPsQowMGoxMM7obUuRog1say4MvcQowQHs5II7792oBBvSmJlVWpRfnxR aU5q8SFGU6CjJjJLiSbnA+MkryTe0NTQ3MLS0NzY3NjMQkmc97xBZZSQQHpiSWp2ampBahFM HxMHp1QDo5C8WNsz1qZVjJ+146350w5tCVeKPfUrZ+LM4qNSWtJN/tEHhG+dKKqIXmV99ZKQ x9EpO9TP3H/6Xcqh58m8x5kRDIkMVZ/kCmrvT2hRZnN55/SgQIf9xI7FO7YqWrJxm00I3Svt yiGTeeZedfOqAPvS3Enmmndfz/8bc3TfzJjzebeuVa9hUmIpzkg01GIuKk4EADcSh1tbAgAA X-CMS-MailID: 20190305162835eucas1p19788f5a6e394ef5be459acc8d5176d09 X-Msg-Generator: CA X-RootMTR: 20190305162835eucas1p19788f5a6e394ef5be459acc8d5176d09 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190305162835eucas1p19788f5a6e394ef5be459acc8d5176d09 References: <20190305162827.9059-1-i.maximets@samsung.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Flavio Leitner Subject: [ovs-dev] [PATCH 1/2] netdev-dpdk: Print netdev name for txq mapping. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org In case of reconfiguration while 'vhost_id' is not set yet, there will be the meaningless message like: |netdev_dpdk|DBG|TX queue mapping for |netdev_dpdk|DBG| 0 --> 0 It's better to print the name of the netdev which is always set. Additionally fixed possible splitting by other log messages and missing space in the queue state message. Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 4f9ca3b3a..93d8e37bb 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -3451,9 +3451,17 @@ netdev_dpdk_remap_txqs(struct netdev_dpdk *dev) } } - VLOG_DBG("TX queue mapping for %s\n", dev->vhost_id); - for (i = 0; i < total_txqs; i++) { - VLOG_DBG("%2d --> %2d", i, dev->tx_q[i].map); + if (VLOG_IS_DBG_ENABLED()) { + struct ds mapping = DS_EMPTY_INITIALIZER; + + ds_put_format(&mapping, "TX queue mapping for port '%s':\n", + netdev_get_name(&dev->up)); + for (i = 0; i < total_txqs; i++) { + ds_put_format(&mapping, "%2d --> %2d\n", i, dev->tx_q[i].map); + } + + VLOG_DBG("%s", ds_cstr(&mapping)); + ds_destroy(&mapping); } free(enabled_queues); @@ -3621,7 +3629,7 @@ vring_state_changed(int vid, uint16_t queue_id, int enable) ovs_mutex_unlock(&dpdk_mutex); if (exists) { - VLOG_INFO("State of queue %d ( tx_qid %d ) of vhost device '%s'" + VLOG_INFO("State of queue %d ( tx_qid %d ) of vhost device '%s' " "changed to \'%s\'", queue_id, qid, ifname, (enable == 1) ? "enabled" : "disabled"); } else {