[ovs-dev] ovs-actions.xml: Fix inconsistency in documentation of controller action.

Message ID 20190304234319.20957-1-blp@ovn.org
State New
Headers show
Series
  • [ovs-dev] ovs-actions.xml: Fix inconsistency in documentation of controller action.
Related show

Commit Message

Ben Pfaff March 4, 2019, 11:43 p.m.
"controller_id" was written as "controller-id" in one place.  This spells
it consistently.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 lib/ovs-actions.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Numan Siddique March 5, 2019, 4:05 p.m. | #1
On Tue, Mar 5, 2019 at 5:29 AM Ben Pfaff <blp@ovn.org> wrote:

> "controller_id" was written as "controller-id" in one place.  This spells
> it consistently.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>

Acked-by: Numan Siddique <nusiddiq@redhat.com>


> ---
>  lib/ovs-actions.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ovs-actions.xml b/lib/ovs-actions.xml
> index 84df842a1937..edf0511c6e5b 100644
> --- a/lib/ovs-actions.xml
> +++ b/lib/ovs-actions.xml
> @@ -699,7 +699,7 @@ $ ovs-ofctl -O OpenFlow10 add-flow br0
> actions=mod_nw_src:1.2.3.4
>
>          <dt><code>id=</code><var>controller_id</var></dt>
>          <dd>
> -          Specify <var>controller-id</var>, a 16-bit integer, as the
> connection
> +          Specify <var>controller_id</var>, a 16-bit integer, as the
> connection
>            ID of the OpenFlow controller or controllers to which the
>            ``packet-in'' message should be sent.  The default is zero.
> Zero is
>            also the default connection ID for each controller connection,
> and a
> --
> 2.20.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Ben Pfaff March 5, 2019, 9:21 p.m. | #2
On Tue, Mar 05, 2019 at 09:35:58PM +0530, Numan Siddique wrote:
> On Tue, Mar 5, 2019 at 5:29 AM Ben Pfaff <blp@ovn.org> wrote:
> 
> > "controller_id" was written as "controller-id" in one place.  This spells
> > it consistently.
> >
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> Acked-by: Numan Siddique <nusiddiq@redhat.com>

Thanks, applied to master.

Patch

diff --git a/lib/ovs-actions.xml b/lib/ovs-actions.xml
index 84df842a1937..edf0511c6e5b 100644
--- a/lib/ovs-actions.xml
+++ b/lib/ovs-actions.xml
@@ -699,7 +699,7 @@  $ ovs-ofctl -O OpenFlow10 add-flow br0 actions=mod_nw_src:1.2.3.4
 
         <dt><code>id=</code><var>controller_id</var></dt>
         <dd>
-          Specify <var>controller-id</var>, a 16-bit integer, as the connection
+          Specify <var>controller_id</var>, a 16-bit integer, as the connection
           ID of the OpenFlow controller or controllers to which the
           ``packet-in'' message should be sent.  The default is zero.  Zero is
           also the default connection ID for each controller connection, and a