From patchwork Wed Feb 20 15:53:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 1045428 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 444Mdq38rjz9s9L for ; Thu, 21 Feb 2019 02:55:58 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 585252C12; Wed, 20 Feb 2019 15:55:55 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4DB862B4F for ; Wed, 20 Feb 2019 15:54:00 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 314877E9 for ; Wed, 20 Feb 2019 15:53:59 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id i16so18324725wrs.13 for ; Wed, 20 Feb 2019 07:53:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PH3Tg+2wWfqunNCDmxJmCovqWOtJAcZZWny6AawBoRc=; b=C88PdQxAvSyjvirBYZk6+p97elDJqtI7gt17mE4vAhTWaUb4aWDpHP6yM38w/R9xwn shIjR5x8WonnpkL3uKmRQj6uEnEH0gL+2RaU9IgLlq/QcBl0IFtvfTssgeoLjnwUefjB HSwOH+me5MqPhXqYj/c6JJ1jfxkXvg23zekhueKelnJlhUNC4UKNkfCV+dPF0nJ9pZss dbPzboLyAuHE4jeKEtxlUI4N8+Qkh78RLZXcexXkYHHn7boxAocSiGuVT1L/0keCmkuR 5UPRYTt1/GluiS+acafa+xE3Am0zqplaNlnzcfXTDD7LCN/awNrDbYEwcD3r7nRT0QkE SWzQ== X-Gm-Message-State: AHQUAub7yt/HTcv29M/0/iKUWJ/ajCJQY033KAz+pbtl307KPgmt0UAp qA6BjE3Z7NxtQks2EbWULeRduMhmY24= X-Google-Smtp-Source: AHgI3IYSStiQEOiwfQMn7su8AetCQMC3YRZMfd6JonfuV/n4Ji738BAn4oOIoOvTI8o4qXdOJE7k1Q== X-Received: by 2002:adf:ec41:: with SMTP id w1mr25967346wrn.184.1550678037328; Wed, 20 Feb 2019 07:53:57 -0800 (PST) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id h9sm15594840wrv.11.2019.02.20.07.53.56 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 20 Feb 2019 07:53:56 -0800 (PST) From: Lorenzo Bianconi To: ovs-dev@openvswitch.org Date: Wed, 20 Feb 2019 16:53:45 +0100 Message-Id: <60e204ca0aa16d89599eb4cd5ad0be6550458f7a.1550677847.git.lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] OVN: select a random mac_prefix if not provided X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Select a random IPAM mac_prefix if it has not been provided by the user. With this patch the admin can avoid to configure mac_prefix in order to avoid L2 address collisions if multiple OVN deployments share the same broadcast domain. Remove MAC_ADDR_PREFIX definitions/occurrences since now mac_prefix is always provided to ovn-northd Tested-by: Miguel Duarte de Mora Barroso Signed-off-by: Lorenzo Bianconi --- ovn/northd/ovn-northd.c | 30 +++++++++++------------------- tests/ovn.at | 3 +++ 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 3569ea2be..2b7a3634e 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -62,7 +62,6 @@ static const char *ovnnb_db; static const char *ovnsb_db; static const char *unixctl_path; -#define MAC_ADDR_PREFIX 0x0A0000000000ULL #define MAC_ADDR_SPACE 0xffffff /* MAC address management (macam) table of "struct eth_addr"s, that holds the @@ -937,13 +936,8 @@ ipam_insert_mac(struct eth_addr *ea, bool check) } uint64_t mac64 = eth_addr_to_uint64(*ea); - uint64_t prefix; + uint64_t prefix = eth_addr_to_uint64(mac_prefix); - if (!eth_addr_is_zero(mac_prefix)) { - prefix = eth_addr_to_uint64(mac_prefix); - } else { - prefix = MAC_ADDR_PREFIX; - } /* If the new MAC was not assigned by this address management system or * check is true and the new MAC is a duplicate, do not insert it into the * macam hmap. */ @@ -1056,11 +1050,7 @@ ipam_get_unused_mac(ovs_be32 ip) for (i = 0; i < MAC_ADDR_SPACE - 1; i++) { /* The tentative MAC's suffix will be in the interval (1, 0xfffffe). */ mac_addr_suffix = ((base_addr + i) % (MAC_ADDR_SPACE - 1)) + 1; - if (!eth_addr_is_zero(mac_prefix)) { - mac64 = eth_addr_to_uint64(mac_prefix) | mac_addr_suffix; - } else { - mac64 = MAC_ADDR_PREFIX | mac_addr_suffix; - } + mac64 = eth_addr_to_uint64(mac_prefix) | mac_addr_suffix; eth_addr_from_uint64(mac64, &mac); if (!ipam_is_duplicate_mac(&mac, mac64, true)) { break; @@ -1132,13 +1122,7 @@ dynamic_mac_changed(const char *lsp_addresses, } uint64_t mac64 = eth_addr_to_uint64(update->current_addresses.ea); - uint64_t prefix; - - if (!eth_addr_is_zero(mac_prefix)) { - prefix = eth_addr_to_uint64(mac_prefix); - } else { - prefix = MAC_ADDR_PREFIX; - } + uint64_t prefix = eth_addr_to_uint64(mac_prefix); if ((mac64 ^ prefix) >> 24) { return DYNAMIC; @@ -7300,6 +7284,14 @@ ovnnb_db_run(struct northd_context *ctx, &addr.ea[0], &addr.ea[1], &addr.ea[2])) { mac_prefix = addr; } + } else { + eth_addr_random(&mac_prefix); + memset(&mac_prefix.ea[3], 0, 3); + + char *addr_prefix = xasprintf(ETH_ADDR_FMT, ETH_ADDR_ARGS(mac_prefix)); + smap_add((struct smap *)&nb->options, "mac_prefix", addr_prefix); + nbrec_nb_global_set_options(nb, &nb->options); + free(addr_prefix); } cleanup_macam(&macam); diff --git a/tests/ovn.at b/tests/ovn.at index cfdbf412c..7e69808ed 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -5416,6 +5416,7 @@ ovn_start # Add a port to a switch that does not have a subnet set, then set the # subnet which should result in an address being allocated for the port. +ovn-nbctl --wait=hv set NB_Global . options:mac_prefix="0a:00:00:00:00:00" ovn-nbctl ls-add sw0 ovn-nbctl lsp-add sw0 p0 -- lsp-set-addresses p0 dynamic ovn-nbctl --wait=sb add Logical-Switch sw0 other_config subnet=192.168.1.0/24 @@ -5801,6 +5802,7 @@ ovn_start ovn-nbctl lr-add R1 # Test for a ping using dynamically allocated addresses. +ovn-nbctl --wait=hv set NB_Global . options:mac_prefix="0a:00:00:00:00:00" ovn-nbctl ls-add foo -- add Logical_Switch foo other_config subnet=192.168.1.0/24 ovn-nbctl ls-add alice -- add Logical_Switch alice other_config subnet=192.168.2.0/24 @@ -12052,6 +12054,7 @@ AT_CLEANUP AT_SETUP([ovn -- ipam to non-ipam]) ovn_start +ovn-nbctl --wait=hv set NB_Global . options:mac_prefix="0a:00:00:00:00:00" ovn-nbctl ls-add sw0 ovn-nbctl lsp-add sw0 p0 -- lsp-set-addresses p0 dynamic ovn-nbctl --wait=sb add Logical-Switch sw0 other_config subnet=192.168.1.0/24