diff mbox series

[2/3] package/imagemagick: add prompt for host variant

Message ID 3833_1550582141_5C6C017D_3833_428_1_8b3762a4-694a-45cd-8cac-301fd3ba7526@OPEXCLILMA1.corporate.adroot.infra.ftgroup
State Accepted
Headers show
Series None | expand

Commit Message

Yann E. MORIN Feb. 19, 2019, 1:15 p.m. UTC 
From: "Yann E. MORIN" <yann.morin@orange.com>

Sometimes, it is required to call imagemagick from a posr-build script
or the likes, so we have to allow the user to enable the host variant
for imagemagick.

Update the linux package to select the host variant now.

Signed-off-by: "Yann E. MORIN" <yann.morin@orange.com>
---
 linux/Config.in                    |  1 +
 package/Config.in.host             |  1 +
 package/imagemagick/Config.in.host | 13 +++++++++++++
 3 files changed, 15 insertions(+)
 create mode 100644 package/imagemagick/Config.in.host

Comments

Thomas Petazzoni June 23, 2019, 4 p.m. UTC | #1 
Hello,

On Tue, 19 Feb 2019 14:15:29 +0100
<yann.morin@orange.com> wrote:

> diff --git a/linux/Config.in b/linux/Config.in
> index 323ba38d72..8466332dfe 100644
> --- a/linux/Config.in
> +++ b/linux/Config.in
> @@ -2,6 +2,7 @@ menu "Kernel"
>  
>  config BR2_LINUX_KERNEL
>  	bool "Linux Kernel"
> +	select BR2_PACKAGE_HOST_IMAGEMAGICK if BR2_LINUX_KERNEL_CUSTOM_LOGO_PATH != ""

We don't really consistently select the option of host packages. For
example, pkgconf has a host option, and we clearly don't select from
all the packages that have a dependency on host-pkgconf.

But well, it doesn't hurt to do so, especially in this case where
there's only one location which selects host-imagemagick.

> +	bool "host-imagemagick"

We use "host foo" as the prompt for host packages and not "host-foo",
so I tweaked this.

Applied, thanks!

Thomas
diff mbox series

Patch

diff --git a/linux/Config.in b/linux/Config.in
index 323ba38d72..8466332dfe 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -2,6 +2,7 @@  menu "Kernel"
 
 config BR2_LINUX_KERNEL
 	bool "Linux Kernel"
+	select BR2_PACKAGE_HOST_IMAGEMAGICK if BR2_LINUX_KERNEL_CUSTOM_LOGO_PATH != ""
 	help
 	  Enable this option if you want to build a Linux kernel for
 	  your embedded device
diff --git a/package/Config.in.host b/package/Config.in.host
index b4c501a33b..48f4f7e61d 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -27,6 +27,7 @@  menu "Host utilities"
 	source "package/go-bootstrap/Config.in.host"
 	source "package/google-breakpad/Config.in.host"
 	source "package/gptfdisk/Config.in.host"
+	source "package/imagemagick/Config.in.host"
 	source "package/imx-mkimage/Config.in.host"
 	source "package/imx-usb-loader/Config.in.host"
 	source "package/jq/Config.in.host"
diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
new file mode 100644
index 0000000000..b6d2a379f8
--- /dev/null
+++ b/package/imagemagick/Config.in.host
@@ -0,0 +1,13 @@ 
+config BR2_PACKAGE_HOST_IMAGEMAGICK
+	bool "host-imagemagick"
+	help
+	  ImageMagick(R) is a software suite to create, edit, and
+	  compose bitmap images. It can read, convert and write images
+	  in a variety of formats (about 100) including DPX, EXR, GIF,
+	  JPEG, JPEG-2000, PDF, PhotoCD, PNG, Postscript, SVG, and TIFF.
+	  Use ImageMagick to translate, flip, mirror, rotate, scale,
+	  shear and transform images, adjust image colors, apply various
+	  special effects, or draw text, lines, polygons, ellipses and
+	  Bézier curves.
+
+	  http://www.imagemagick.org/