| Message ID | 20190215174003.33063-1-posk@google.com |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] bpf: make LWTUNNEL_BPF dependent on INET | expand |
On 02/15/2019 09:40 AM, Peter Oskolkov wrote: > Lightweight tunnels are L3 constructs that are used with IP/IP6. > Make the dependency explicit at least for LWT-BPF, as now they > call into IP routing. > > Signed-off-by: Peter Oskolkov <posk@google.com> > --- > net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/Kconfig b/net/Kconfig > index 5cb9de1aaf88..62da6148e9f8 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -403,7 +403,7 @@ config LWTUNNEL > > config LWTUNNEL_BPF > bool "Execute BPF program as route nexthop action" > - depends on LWTUNNEL > + depends on LWTUNNEL && INET > default y if LWTUNNEL=y > ---help--- > Allows to run BPF programs as a nexthop action following a route > It seems you forgot a 'Reported-by:' tag Thanks.
On Fri, Feb 15, 2019 at 9:46 AM Eric Dumazet <eric.dumazet@gmail.com> wrote: > > > > On 02/15/2019 09:40 AM, Peter Oskolkov wrote: > > Lightweight tunnels are L3 constructs that are used with IP/IP6. > > Make the dependency explicit at least for LWT-BPF, as now they > > call into IP routing. > > > > Signed-off-by: Peter Oskolkov <posk@google.com> > > --- > > net/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/Kconfig b/net/Kconfig > > index 5cb9de1aaf88..62da6148e9f8 100644 > > --- a/net/Kconfig > > +++ b/net/Kconfig > > @@ -403,7 +403,7 @@ config LWTUNNEL > > > > config LWTUNNEL_BPF > > bool "Execute BPF program as route nexthop action" > > - depends on LWTUNNEL > > + depends on LWTUNNEL && INET > > default y if LWTUNNEL=y > > ---help--- > > Allows to run BPF programs as a nexthop action following a route > > > > It seems you forgot a 'Reported-by:' tag Fixed: https://patchwork.ozlabs.org/patch/1043108/ > > Thanks.
diff --git a/net/Kconfig b/net/Kconfig index 5cb9de1aaf88..62da6148e9f8 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -403,7 +403,7 @@ config LWTUNNEL config LWTUNNEL_BPF bool "Execute BPF program as route nexthop action" - depends on LWTUNNEL + depends on LWTUNNEL && INET default y if LWTUNNEL=y ---help--- Allows to run BPF programs as a nexthop action following a route
Lightweight tunnels are L3 constructs that are used with IP/IP6. Make the dependency explicit at least for LWT-BPF, as now they call into IP routing. Signed-off-by: Peter Oskolkov <posk@google.com> --- net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)