From patchwork Mon Feb 11 01:48:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Darrell Ball X-Patchwork-Id: 1039556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Myk47Z8M"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43yTKc1WBXz9sBZ for ; Mon, 11 Feb 2019 12:51:32 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 328DD1CE9; Mon, 11 Feb 2019 01:49:39 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 033DF1C0D for ; Mon, 11 Feb 2019 01:49:18 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id C457B5E4 for ; Mon, 11 Feb 2019 01:49:17 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id j3so4485352pfi.12 for ; Sun, 10 Feb 2019 17:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=EByjOjpFsENuwmJWhluEl0yFSbKE1iAqpi6Sv9WLjsQ=; b=Myk47Z8M4cAs82RMW6kWc/8N9+nBHgoluBESVmbfEL8RNquMSrBapJRJpuGDcLJynT VzUFD1uXVw8J35hyKD4fuAHS3FGE108od63d5t1XdIoMHsH3rQExyJegHf8pqEnyZ9Ba CQS2pT6iaS1Puj6MgPBeISKcDcp6l8BnjNnnzG3CrDgq7JX4RnFdGEgWF5231eShDL1H ueIrP+xxsAUH9bixBz5dgj9ZglMyrAVLFsL3wXc+HGbihORKAO+AcIt+gIHOWn0knJ8N HFHc8zv+GYS7g7MYAHv3yF7KTVFLhBbp8IPCx3G/XqmqZNYi8su+FcWJLjWFLNCxF8JH On+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=EByjOjpFsENuwmJWhluEl0yFSbKE1iAqpi6Sv9WLjsQ=; b=evLty84ZNZpC/1nt0/KuIEzVsDQbkLAt4j3APareHABVQNK/pifVODkVco/9/VfRlh OPrpzl8Nk9n6cUFLzwA9L7G5KWmRiqY9jPHjTCseNoDExmHMSUBHSZ2DhUh+nRKi50gC 6dr6oqyrrUcFgyhhDlmRGvOo22+VuKUS2vGtM/ci0YNlqnFBGaQP+LgyKc++vyCbRnmS Hf9NBb6Ti3fwX2WWz9GU7TvCkvFunWoDdwTV0ZNIwz/SMDHDPnry0pcwO7uzAjGMDQcj h0rgOlZuI2u8LirCKGuXP7OUyEGy2wgqNOhJY81kHD4iUNUklZ8C3EqtDqGbs/oPFwXc esHQ== X-Gm-Message-State: AHQUAuZb5mxzSaqwuZ9xk2d3ikcGcLrb/vOCUN/7oERrI0cflIFA+JRi 4mD5rdnw7hNGGTQKvKz2RWI= X-Google-Smtp-Source: AHgI3IY+t9E1bRABHvy5seMKU0zJiKsXIVk41yhx4RxKPWO80EGDy0hAYnAh5kw+ppGCrQU91CoRAA== X-Received: by 2002:a62:8c11:: with SMTP id m17mr34344737pfd.224.1549849757429; Sun, 10 Feb 2019 17:49:17 -0800 (PST) Received: from ubuntu.localdomain (c-76-102-76-212.hsd1.ca.comcast.net. [76.102.76.212]) by smtp.gmail.com with ESMTPSA id p13sm11723152pgs.89.2019.02.10.17.49.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 10 Feb 2019 17:49:17 -0800 (PST) From: Darrell Ball To: dlu998@gmail.com, dev@openvswitch.org Date: Sun, 10 Feb 2019 17:48:32 -0800 Message-Id: <1549849716-55869-5-git-send-email-dlu998@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1549849716-55869-1-git-send-email-dlu998@gmail.com> References: <1549849716-55869-1-git-send-email-dlu998@gmail.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [patch v11 4/8] conntrack: Reword conntrack_execute() description. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Use 'must' instead of 'should'. Suggested-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 3bbe93f..b821c2d 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1298,7 +1298,7 @@ process_one(struct conntrack *ct, struct dp_packet *pkt, } /* Sends the packets in '*pkt_batch' through the connection tracker 'ct'. All - * the packets should have the same 'dl_type' (IPv4 or IPv6) and should have + * the packets must have the same 'dl_type' (IPv4 or IPv6) and should have * the l3 and and l4 offset properly set. * * If 'commit' is true, the packets are allowed to create new entries in the