diff mbox series

[U-Boot] drivers: net: ldpaa_eth: fix resource leak

Message ID 20190208141055.30589-1-pankaj.bansal@nxp.com
State Accepted
Commit 4b0880d66baa1b96c6293051a03af0ad1bee7cb0
Delegated to: Joe Hershberger
Headers show
Series [U-Boot] drivers: net: ldpaa_eth: fix resource leak | expand

Commit Message

Pankaj Bansal Feb. 8, 2019, 8:46 a.m. UTC 
if an error occurs in ldpaa_eth_init, need to free all resources
before returning the error.

Threfore, free net_dev before returning from ldpaa_eth_init.

Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>

Comments

Joe Hershberger Feb. 8, 2019, 8:09 p.m. UTC | #1 
On Fri, Feb 8, 2019 at 2:46 AM Pankaj Bansal <pankaj.bansal@nxp.com> wrote:
>
> if an error occurs in ldpaa_eth_init, need to free all resources
> before returning the error.
>
> Threfore, free net_dev before returning from ldpaa_eth_init.
>
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger March 5, 2019, 6:04 p.m. UTC | #2 
Hi Pankaj,

https://patchwork.ozlabs.org/patch/1038527/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox series

Patch

diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c
index 73b7ba29df..34253e3924 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.c
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
@@ -1074,6 +1074,7 @@  int ldpaa_eth_init(int dpmac_id, phy_interface_t enet_if)
 	priv = (struct ldpaa_eth_priv *)malloc(sizeof(struct ldpaa_eth_priv));
 	if (!priv) {
 		printf("ldpaa_eth_priv malloc() failed\n");
+		free(net_dev);
 		return -ENOMEM;
 	}
 	memset(priv, 0, sizeof(struct ldpaa_eth_priv));