From patchwork Fri Feb 1 13:11:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1034755 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="ONwtC2qD"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43rd2m2hwtz9sDr for ; Sat, 2 Feb 2019 00:18:24 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3DF4C76D2; Fri, 1 Feb 2019 13:16:43 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id F1A6876B4 for ; Fri, 1 Feb 2019 13:11:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 84DB7608 for ; Fri, 1 Feb 2019 13:11:41 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190201131140euoutp02b1b75a29434641d3ed1ecf3ef3123c30~-P5Oko6LZ3161131611euoutp020 for ; Fri, 1 Feb 2019 13:11:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190201131140euoutp02b1b75a29434641d3ed1ecf3ef3123c30~-P5Oko6LZ3161131611euoutp020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1549026700; bh=TMs/uZp+RPJa5nZmsoLyJXXNUuTOY6lXtyPz+hNDiIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ONwtC2qDMq0Gj8l5ulXPpOQRCNh0B9Mytkup8SrxoJA8JJrz9f0dmDQQLbjeHvZre K67amhLme8MobWZrRKyDLnYSHmbIZi6MI3WjiyKimyCnryuAVZw8uApOKM903/g8D1 3NiEhUhoKO6QBcaHQsjPJnOfCSL8XH3fXDX5QkDY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190201131139eucas1p2ca6001b16141fd3f8268219c0bd2f3a2~-P5ONFUAu0880708807eucas1p2i; Fri, 1 Feb 2019 13:11:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 79.27.04806.B85445C5; Fri, 1 Feb 2019 13:11:39 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190201131138eucas1p1223cc65346b164a8d91f3e1b3b5195f3~-P5NYRdpt2738327383eucas1p1s; Fri, 1 Feb 2019 13:11:38 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190201131138eusmtrp15741fe12ddb87552a2d2981878aa324b~-P5NKAjme2949729497eusmtrp1X; Fri, 1 Feb 2019 13:11:38 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-14-5c54458b040c Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 3D.C2.04284.A85445C5; Fri, 1 Feb 2019 13:11:38 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190201131137eusmtip1bf20d18a7b9dda3dd60f7b5145ba28d4~-P5MhETfl1130411304eusmtip1j; Fri, 1 Feb 2019 13:11:37 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ian Stokes Date: Fri, 1 Feb 2019 16:11:14 +0300 Message-Id: <20190201131114.29799-4-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190201131114.29799-1-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsWy7djP87rdriExBqe75Sx+vXnAbvFqcgOj xZX2n+wWGx+eZbVYe+gDu8XcT88ZHdg8Fu95yeTx7OZ/Ro/n13pYPN7vu8rm0bdlFWMAaxSX TUpqTmZZapG+XQJXxuLF91kLHvFXrFt6j62BsZ+7i5GTQ0LAROL9vs3MXYxcHEICKxglnpw8 xgrhfGGU2Nl6HSrzmVFiz62frDAtZ979hKpazijRf3E+C0hCSOAHo8T9A1kgNpuAjsSp1UcY QWwRATuJaauamEAamAV6GSWm3rrMBpIQFgiUeP/pCzuIzSKgKjH94UWgdRwcvALWEqdW8UMs k5dYveEAM4jNKWAj8Wn6DLA5EgKv2SRW/p7PDlHkIjGx8zIjhC0s8er4Fqi4jMTpyT0sEHa9 xP2Wl4wQzR2MEtMP/WOCSNhLbHl9jh1kMbOApsT6XfoQYUeJd+8awe6REOCTuPFWECTMDGRO 2jYdKswr0dEmBFGtIvH74HJmCFtK4ua7z+wQJR4Sx6dmQYKqn1Hi6NYpbBMY5Wch7FrAyLiK UTy1tDg3PbXYOC+1XK84Mbe4NC9dLzk/dxMjMDWc/nf86w7GfX+SDjEKcDAq8fBu+BUUI8Sa WFZcmXuIUYKDWUmEd4VLSIwQb0piZVVqUX58UWlOavEhRmkOFiVx3mqGB9FCAumJJanZqakF qUUwWSYOTqkGxlmR1XVyHezmErlF2evSi8rD7DqO96t3dkf6ysXqvVZtet5hsPheQdZDRlVd hYzfTdIzsuQLHL4wXIsJYHgs+mVR2eOiGI/GxlSHSZfblv7UePkuZgPjcbHJF91nF/Ae8Hta kcX9IP20oojcvTX/njxV0HScfbpNTC9de9+HFwEqjzocI8uVWIozEg21mIuKEwGv1pxOCQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xu7pdriExBgdfK1n8evOA3eLV5AZG iyvtP9ktNj48y2qx9tAHdou5n54zOrB5LN7zksnj2c3/jB7Pr/WweLzfd5XNo2/LKsYA1ig9 m6L80pJUhYz84hJbpWhDCyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9jMWL77MW POKvWLf0HlsDYz93FyMnh4SAicSZdz9Zuxi5OIQEljJKXP7/kgkiISXx49cFVghbWOLPtS42 iKJvjBKdrbOYQRJsAjoSp1YfYQSxRQQcJDbfXQw2iVlgIqPE2am9YJOEBfwl7hx8ywJiswio Skx/eBGomYODV8Ba4tQqfogF8hKrNxwAm8kpYCPxafoMJpASIaCS9gmKExj5FjAyrGIUSS0t zk3PLTbUK07MLS7NS9dLzs/dxAgM1W3Hfm7ewXhpY/AhRgEORiUe3g2/gmKEWBPLiitzDzFK cDArifCucAmJEeJNSaysSi3Kjy8qzUktPsRoCnTSRGYp0eR8YBzllcQbmhqaW1gamhubG5tZ KInznjeojBISSE8sSc1OTS1ILYLpY+LglGpg9CpbWPpsyh/2k1a5r9Lez1s9Z18vn6V4sorQ sZ9bC18cXxMm932tsj/37+svJst6LplxUXDPrp7H/dMyTYQFWE/sLTDXvf76n+M0XSUzbyfD mXJrWkWlV97fM93T1Pbf3nwetqzXDwWOb0qNfnyA5e49T5vlbZ0xa3kd3+bx7j+qfKBw3iqm v0osxRmJhlrMRcWJAP5CgC9rAgAA X-CMS-MailID: 20190201131138eucas1p1223cc65346b164a8d91f3e1b3b5195f3 X-Msg-Generator: CA X-RootMTR: 20190201131138eucas1p1223cc65346b164a8d91f3e1b3b5195f3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190201131138eucas1p1223cc65346b164a8d91f3e1b3b5195f3 References: <20190201131114.29799-1-i.maximets@samsung.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [RFC 3/3] dpdk: Silently ignore unsupported options for EAL arguments. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Remove all the warnings and silently ignores all the old configuration knobs. Signed-off-by: Ilya Maximets --- lib/dpdk.c | 35 ----------------------------------- 1 file changed, 35 deletions(-) diff --git a/lib/dpdk.c b/lib/dpdk.c index fe271ce84..7585729ab 100644 --- a/lib/dpdk.c +++ b/lib/dpdk.c @@ -91,39 +91,6 @@ args_contains(const struct svec *args, const char *value) return false; } -static void -report_unsupported_configs(const struct smap *ovs_other_config) -{ - struct option { - const char *opt; - const char *replacement; - } options[] = { - { "dpdk-alloc-mem", "-m" }, - { "dpdk-socket-mem", "--socket-mem" }, - { "dpdk-socket-limit", "--socket-limit" }, - { "dpdk-lcore-mask", "-c" }, - { "dpdk-hugepage-dir", "--huge-dir" }, - { "dpdk-extra", "" } - }; - int i; - bool found = false; - - for (i = 0; i < ARRAY_SIZE(options); i++) { - const char *value = smap_get(ovs_other_config, options[i].opt); - - if (value) { - VLOG_WARN("Detected unsupported '%s' config. Use '%s %s'" - " in 'dpdk-options' instead. Value ignored.", - options[i].opt, options[i].replacement, value); - found = true; - } - } - if (found) { - VLOG_WARN("Unsupported options will be " - "silently ignored in the future."); - } -} - static ssize_t dpdk_log_write(void *c OVS_UNUSED, const char *buf, size_t size) { @@ -216,8 +183,6 @@ dpdk_init__(const struct smap *ovs_other_config) VLOG_INFO("Per port memory for DPDK devices %s.", per_port_memory ? "enabled" : "disabled"); - report_unsupported_configs(ovs_other_config); - svec_add(&args, ovs_get_program_name()); dpdk_options = smap_get(ovs_other_config, "dpdk-options");