[ovs-dev,RFC,3/3] dpdk: Silently ignore unsupported options for EAL arguments.

Message ID 20190201131114.29799-4-i.maximets@samsung.com
State New
Delegated to: Ian Stokes
Headers show
Series
  • dpdk: Unification/deprecation of DPDK EAL config knobs.
Related show

Commit Message

Ilya Maximets Feb. 1, 2019, 1:11 p.m.
Remove all the warnings and silently ignores all the old configuration
knobs.

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 lib/dpdk.c | 35 -----------------------------------
 1 file changed, 35 deletions(-)

Patch

diff --git a/lib/dpdk.c b/lib/dpdk.c
index fe271ce84..7585729ab 100644
--- a/lib/dpdk.c
+++ b/lib/dpdk.c
@@ -91,39 +91,6 @@  args_contains(const struct svec *args, const char *value)
     return false;
 }
 
-static void
-report_unsupported_configs(const struct smap *ovs_other_config)
-{
-    struct option {
-        const char *opt;
-        const char *replacement;
-    } options[] = {
-        { "dpdk-alloc-mem",    "-m"             },
-        { "dpdk-socket-mem",   "--socket-mem"   },
-        { "dpdk-socket-limit", "--socket-limit" },
-        { "dpdk-lcore-mask",   "-c"             },
-        { "dpdk-hugepage-dir", "--huge-dir"     },
-        { "dpdk-extra",        ""               }
-    };
-    int i;
-    bool found = false;
-
-    for (i = 0; i < ARRAY_SIZE(options); i++) {
-        const char *value = smap_get(ovs_other_config, options[i].opt);
-
-        if (value) {
-            VLOG_WARN("Detected unsupported '%s' config. Use '%s %s'"
-                      " in 'dpdk-options' instead. Value ignored.",
-                      options[i].opt, options[i].replacement, value);
-            found = true;
-        }
-    }
-    if (found) {
-        VLOG_WARN("Unsupported options will be "
-                  "silently ignored in the future.");
-    }
-}
-
 static ssize_t
 dpdk_log_write(void *c OVS_UNUSED, const char *buf, size_t size)
 {
@@ -216,8 +183,6 @@  dpdk_init__(const struct smap *ovs_other_config)
     VLOG_INFO("Per port memory for DPDK devices %s.",
               per_port_memory ? "enabled" : "disabled");
 
-    report_unsupported_configs(ovs_other_config);
-
     svec_add(&args, ovs_get_program_name());
     dpdk_options = smap_get(ovs_other_config, "dpdk-options");