From patchwork Mon Jan 28 05:49:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li RongQing X-Patchwork-Id: 1031679 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=baidu.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43nzGw19KCz9s7h for ; Mon, 28 Jan 2019 16:49:42 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 355361A73; Mon, 28 Jan 2019 05:49:39 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id A07101A6F for ; Mon, 28 Jan 2019 05:49:13 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from tc-sys-mailedm01.tc.baidu.com (mx59.baidu.com [61.135.168.59]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 045827C for ; Mon, 28 Jan 2019 05:49:12 +0000 (UTC) Received: from localhost (cp01-cos-dev01.cp01.baidu.com [10.92.119.46]) by tc-sys-mailedm01.tc.baidu.com (Postfix) with ESMTP id 7CB1C204004F for ; Mon, 28 Jan 2019 13:49:09 +0800 (CST) From: Li RongQing To: dev@openvswitch.org Date: Mon, 28 Jan 2019 13:49:09 +0800 Message-Id: <1548654549-9016-1-git-send-email-lirongqing@baidu.com> X-Mailer: git-send-email 1.7.1 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] flow: fix a possible memory leak in parse_ct_state X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org state_s should be freed always before exit parse_ct_state Signed-off-by: Li RongQing Acked-by: Ilya Maximets --- lib/flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/flow.c b/lib/flow.c index c6e47781b..479b7fe46 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -1261,6 +1261,7 @@ parse_ct_state(const char *state_str, uint32_t default_state, if (!bit) { ds_put_format(ds, "%s: unknown connection tracking state flag", cs); + free(state_s); return false; } state |= bit;