diff mbox series

[U-Boot,v3,4/6] net: phy: ar803x: Explicitly disable RGMII delays

Message ID 1548463214-18159-5-git-send-email-vladimir.oltean@nxp.com
State Superseded
Commit 5b6f1dc
Delegated to: Joe Hershberger
Headers show
Series net: phy: Allow disabling SmartEEE for Atheros PHYs | expand

Commit Message

Vladimir Oltean Jan. 26, 2019, 12:40 a.m. UTC 
To eliminate any doubts about the out-of-reset value of the PHY, that
the driver previously relied on.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Changes in v3:
 * Patch added in this version.

 drivers/net/phy/atheros.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Joe Hershberger Feb. 4, 2019, 11:03 p.m. UTC | #1 
On Fri, Jan 25, 2019 at 6:43 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> To eliminate any doubts about the out-of-reset value of the PHY, that
> the driver previously relied on.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Acked-by: Joe Hershberger <joe.hreshberger@ni.com>
Joe Hershberger March 5, 2019, 6:04 p.m. UTC | #2 
Hi Vladimir,

https://patchwork.ozlabs.org/patch/1031365/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox series

Patch

diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
index 72e7fac..02aa61f 100644
--- a/drivers/net/phy/atheros.c
+++ b/drivers/net/phy/atheros.c
@@ -82,10 +82,14 @@  static int ar8031_config(struct phy_device *phydev)
 	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
 	    phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
 		ar803x_enable_tx_delay(phydev, true);
+	else
+		ar803x_enable_tx_delay(phydev, false);
 
 	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID ||
 	    phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
 		ar803x_enable_rx_delay(phydev, true);
+	else
+		ar803x_enable_rx_delay(phydev, false);
 
 	phydev->supported = phydev->drv->features;
 
@@ -113,10 +117,14 @@  static int ar8035_config(struct phy_device *phydev)
 	if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
 	    (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID))
 		ar803x_enable_tx_delay(phydev, true);
+	else
+		ar803x_enable_tx_delay(phydev, false);
 
 	if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
 	    (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID))
 		ar803x_enable_rx_delay(phydev, true);
+	else
+		ar803x_enable_rx_delay(phydev, false);
 
 	phydev->supported = phydev->drv->features;