diff mbox series

rs6000: Fix *movsi_from_df (PR88892)

Message ID bc7ccd386c8b33bc53381336787d72264dd96dce.1547831579.git.segher@kernel.crashing.org
State New
Headers show
Series rs6000: Fix *movsi_from_df (PR88892) | expand

Commit Message

Segher Boessenkool Jan. 18, 2019, 5:14 p.m. UTC 
The memory store instructions (stfs[u][x], stxssp[x]) can result in
garbage if the value to be stored isn't already a valid single
precision floating point number.  So we cannot use this here.

This needs backporting to 8, according to the PR.

Tested etc.; committing to trunk.


Segher


2019-01-18  Segher Boessenkool  <segher@kernel.crashing.org>

	PR target/88892
	* config/rs6000/rs6000.md (*movsi_from_df): Allow only register
	operands.

---
 gcc/config/rs6000/rs6000.md | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)
diff mbox series

Patch

diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 13970f3..d59b46f 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -7015,24 +7015,19 @@  (define_insn_and_split "*movdi_from_sf_zero_ext"
 		 8,          4")])
 
 ;; Like movsi_from_sf, but combine a convert from DFmode to SFmode before
-;; moving it to SImode.  We can do a SFmode store without having to do the
-;; conversion explicitly.  If we are doing a register->register conversion, use
-;; XSCVDPSP instead of XSCVDPSPN, since the former handles cases where the
-;; input will not fit in a SFmode, and the later assumes the value has already
-;; been rounded.
+;; moving it to SImode.  We cannot do a SFmode store without having to do the
+;; conversion explicitly since that doesn't work in most cases if the input
+;; isn't representable as SF.  Use XSCVDPSP instead of XSCVDPSPN, since the
+;; former handles cases where the input will not fit in a SFmode, and the
+;; latter assumes the value has already been rounded.
 (define_insn "*movsi_from_df"
-  [(set (match_operand:SI 0 "nonimmediate_operand"         "=wa,m,wY,Z")
+  [(set (match_operand:SI 0 "gpc_reg_operand" "=wa")
 	(unspec:SI [(float_truncate:SF
-		     (match_operand:DF 1 "gpc_reg_operand" "wa, f,wb,wa"))]
+		     (match_operand:DF 1 "gpc_reg_operand" "wa"))]
 		    UNSPEC_SI_FROM_SF))]
-
   "TARGET_NO_SF_SUBREG"
-  "@
-   xscvdpsp %x0,%x1
-   stfs%U0%X0 %1,%0
-   stxssp %1,%0
-   stxsspx %x1,%y0"
-  [(set_attr "type"   "fp,fpstore,fpstore,fpstore")])
+  "xscvdpsp %x0,%x1"
+  [(set_attr "type" "fp")])
 
 ;; Split a load of a large constant into the appropriate two-insn
 ;; sequence.