diff mbox series

hostapd: Add support for setting pbss option from config file

Message ID 20190118123945.14675-1-brendan.jackman@bluwirelesstechnology.com
State Accepted
Headers show
Series hostapd: Add support for setting pbss option from config file | expand

Commit Message

Brendan Jackman Jan. 18, 2019, 12:40 p.m. UTC 
From: Ian Archer <ian.archer@bluwirelesstechnology.com>

There is currently no support for setting hostapd_bss_config.pbss
from a config file. This patch adds a key naturally called "pbss"
which can be used to set it.

Cc: Antony King <antony.king@bluwirelesstechnology.com>
Signed-off-by: Brendan Jackman <brendan.jackman@bluwirelesstechnology.com>
---
 hostapd/config_file.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jouni Malinen Jan. 21, 2019, 10:25 p.m. UTC | #1 
On Fri, Jan 18, 2019 at 12:40:15PM +0000, Brendan Jackman wrote:
> There is currently no support for setting hostapd_bss_config.pbss
> from a config file. This patch adds a key naturally called "pbss"
> which can be used to set it.

Thanks, applied. Was this sufficient to get hostapd able to initiate a
PBSS? The past use cases for this has been only through wpa_supplicant
and automatic setup for P2P.
Brendan Jackman Jan. 22, 2019, 11:18 a.m. UTC | #2 
On 22/01/2019 05:25, Jouni Malinen wrote:
> On Fri, Jan 18, 2019 at 12:40:15PM +0000, Brendan Jackman wrote:
>> There is currently no support for setting hostapd_bss_config.pbss
>> from a config file. This patch adds a key naturally called "pbss"
>> which can be used to set it.
> Thanks, applied. Was this sufficient to get hostapd able to initiate a
> PBSS? The past use cases for this has been only through wpa_supplicant
> and automatic setup for P2P.
Great, thanks. Yes - at least on the HW I'm working with, it's enough to bring up a PBSS with hostapd managing the PCP.
diff mbox series

Patch

diff --git a/hostapd/config_file.c b/hostapd/config_file.c
index daaa484f2..e2ca2789b 100644
--- a/hostapd/config_file.c
+++ b/hostapd/config_file.c
@@ -4258,6 +4258,8 @@  static int hostapd_config_fill(struct hostapd_config *conf,
 		conf->rssi_reject_assoc_rssi = atoi(pos);
 	} else if (os_strcmp(buf, "rssi_reject_assoc_timeout") == 0) {
 		conf->rssi_reject_assoc_timeout = atoi(pos);
+	} else if (os_strcmp(buf, "pbss") == 0) {
+		bss->pbss = atoi(pos);
 	} else {
 		wpa_printf(MSG_ERROR,
 			   "Line %d: unknown configuration item '%s'",