| Message ID | 20190117225300.8006-4-jakub.kicinski@netronome.com |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: use strict checks in doit handlers | expand |
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 08f142b59403..3c134b928071 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4927,6 +4927,10 @@ static int rtnl_valid_stats_req(const struct nlmsghdr *nlh, bool strict_check, NL_SET_ERR_MSG(extack, "Invalid attributes after stats header"); return -EINVAL; } + if (ifsm->filter_mask >= IFLA_STATS_FILTER_BIT(IFLA_STATS_MAX + 1)) { + NL_SET_ERR_MSG(extack, "Invalid stats requested through filter mask"); + return -EINVAL; + } return 0; }
In the spirit of strict checks reject requests of stats the kernel does not support when NETLINK_F_STRICT_CHK is set. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> --- net/core/rtnetlink.c | 4 ++++ 1 file changed, 4 insertions(+)