| Message ID | 20190117173907.62198-1-luc.vanoostenryck@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem' | expand |
Hi Luc, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote on Thu, 17 Jan 2019 18:39:07 +0100: > The function jz_nand_ioremap_resource() needs a pointer to an __iomem > pointer as its last argument but this argument is declared as: > void * __iomem *base > > Fix this by using the correct declaration: > void __iomem **base > which then also removes the following Sparse's warnings: > 282:15: warning: incorrect type in assignment (different address spaces) > 282:15: expected void *[noderef] <asn:2> > 282:15: got void [noderef] <asn:2> * > 322:57: warning: incorrect type in argument 4 (different address spaces) > 322:57: expected void *[noderef] <asn:2> *base > 322:57: got void [noderef] <asn:2> ** > 402:67: warning: incorrect type in argument 4 (different address spaces) > 402:67: expected void *[noderef] <asn:2> *base > 402:67: got void [noderef] <asn:2> ** > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > --- Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Boris, do you want to take it in your fixes branch? Thanks, Miquèl
On Thu, 2019-01-17 at 17:39:07 UTC, Luc Van Oostenryck wrote: > The function jz_nand_ioremap_resource() needs a pointer to an __iomem > pointer as its last argument but this argument is declared as: > void * __iomem *base > > Fix this by using the correct declaration: > void __iomem **base > which then also removes the following Sparse's warnings: > 282:15: warning: incorrect type in assignment (different address spaces) > 282:15: expected void *[noderef] <asn:2> > 282:15: got void [noderef] <asn:2> * > 322:57: warning: incorrect type in argument 4 (different address spaces) > 322:57: expected void *[noderef] <asn:2> *base > 322:57: got void [noderef] <asn:2> ** > 402:67: warning: incorrect type in argument 4 (different address spaces) > 402:67: expected void *[noderef] <asn:2> *base > 402:67: got void [noderef] <asn:2> ** > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks. Boris
diff --git a/drivers/mtd/nand/raw/jz4740_nand.c b/drivers/mtd/nand/raw/jz4740_nand.c index f92ae5aa2..9526d5b23 100644 --- a/drivers/mtd/nand/raw/jz4740_nand.c +++ b/drivers/mtd/nand/raw/jz4740_nand.c @@ -260,7 +260,7 @@ static int jz_nand_correct_ecc_rs(struct nand_chip *chip, uint8_t *dat, } static int jz_nand_ioremap_resource(struct platform_device *pdev, - const char *name, struct resource **res, void *__iomem *base) + const char *name, struct resource **res, void __iomem **base) { int ret;
The function jz_nand_ioremap_resource() needs a pointer to an __iomem pointer as its last argument but this argument is declared as: void * __iomem *base Fix this by using the correct declaration: void __iomem **base which then also removes the following Sparse's warnings: 282:15: warning: incorrect type in assignment (different address spaces) 282:15: expected void *[noderef] <asn:2> 282:15: got void [noderef] <asn:2> * 322:57: warning: incorrect type in argument 4 (different address spaces) 322:57: expected void *[noderef] <asn:2> *base 322:57: got void [noderef] <asn:2> ** 402:67: warning: incorrect type in argument 4 (different address spaces) 402:67: expected void *[noderef] <asn:2> *base 402:67: got void [noderef] <asn:2> ** Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> --- drivers/mtd/nand/raw/jz4740_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)