[ovs-dev] ovsdb-server: Correct json-rpc comment for "disable-monitor-cond".

Message ID 20190116225251.123477-1-jpettit@ovn.org
State New
Headers show
Series
  • [ovs-dev] ovsdb-server: Correct json-rpc comment for "disable-monitor-cond".
Related show

Commit Message

Justin Pettit Jan. 16, 2019, 10:52 p.m.
---
 ovsdb/ovsdb-server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

0-day Robot Jan. 17, 2019, 12:26 a.m. | #1
Bleep bloop.  Greetings Justin Pettit, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Justin Pettit <jpettit@ovn.org> needs to sign off.
Lines checked: 26, Warnings: 0, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
Ben Pfaff Jan. 17, 2019, 12:36 a.m. | #2
On Wed, Jan 16, 2019 at 02:52:51PM -0800, Justin Pettit wrote:
> ---
>  ovsdb/ovsdb-server.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
> index 8d213b27aae1..65a47a41d382 100644
> --- a/ovsdb/ovsdb-server.c
> +++ b/ovsdb/ovsdb-server.c
> @@ -1409,7 +1409,7 @@ ovsdb_server_disable_monitor_cond(struct unixctl_conn *conn,
>  
>      ovsdb_jsonrpc_disable_monitor_cond();
>      ovsdb_jsonrpc_server_reconnect(
> -        jsonrpc, true, xstrdup("user ran ovsdb-server/disable-monitor"));
> +        jsonrpc, true, xstrdup("user ran ovsdb-server/disable-monitor-cond"));
>      unixctl_command_reply(conn, NULL);
>  }

Acked-by: Ben Pfaff <blp@ovn.org>
Justin Pettit Jan. 17, 2019, 1:05 a.m. | #3
> On Jan 16, 2019, at 4:36 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> On Wed, Jan 16, 2019 at 02:52:51PM -0800, Justin Pettit wrote:
>> ---
>> ovsdb/ovsdb-server.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
>> index 8d213b27aae1..65a47a41d382 100644
>> --- a/ovsdb/ovsdb-server.c
>> +++ b/ovsdb/ovsdb-server.c
>> @@ -1409,7 +1409,7 @@ ovsdb_server_disable_monitor_cond(struct unixctl_conn *conn,
>> 
>>     ovsdb_jsonrpc_disable_monitor_cond();
>>     ovsdb_jsonrpc_server_reconnect(
>> -        jsonrpc, true, xstrdup("user ran ovsdb-server/disable-monitor"));
>> +        jsonrpc, true, xstrdup("user ran ovsdb-server/disable-monitor-cond"));
>>     unixctl_command_reply(conn, NULL);
>> }
> 
> Acked-by: Ben Pfaff <blp@ovn.org>

Thanks.  I added my Signed-off-by and pushed it.

--Justin

Patch

diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
index 8d213b27aae1..65a47a41d382 100644
--- a/ovsdb/ovsdb-server.c
+++ b/ovsdb/ovsdb-server.c
@@ -1409,7 +1409,7 @@  ovsdb_server_disable_monitor_cond(struct unixctl_conn *conn,
 
     ovsdb_jsonrpc_disable_monitor_cond();
     ovsdb_jsonrpc_server_reconnect(
-        jsonrpc, true, xstrdup("user ran ovsdb-server/disable-monitor"));
+        jsonrpc, true, xstrdup("user ran ovsdb-server/disable-monitor-cond"));
     unixctl_command_reply(conn, NULL);
 }