| Message ID | 650c47f3-8657-0fc9-81bd-63974bbe06a5@cogentembedded.com |
|---|---|
| State | Accepted |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | Untangle Spansion S25F{L|S}512S chip IDs | expand |
On 01/16/2019 07:51 PM, Sergei Shtylyov wrote: > Spansion S25FS512S flash is currently misdetected as S25FL512S since the > latter uses 5-byte JEDEC ID, while the 6th ID byte (family ID) is different > on those chips. Add the 6-byte S25FS512S ID before S25FL512S ID in order > not to break the existing S25FS512S users. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> > > --- > drivers/mtd/spi-nor/spi-nor.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-mtd/drivers/mtd/spi-nor/spi-nor.c > =================================================================== > --- linux-mtd.orig/drivers/mtd/spi-nor/spi-nor.c > +++ linux-mtd/drivers/mtd/spi-nor/spi-nor.c > @@ -1887,6 +1887,7 @@ static const struct flash_info spi_nor_i > { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, USE_CLSR) }, > { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, > + { "s25fs512s", INFO6(0x010220, 0x4d0081, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, > { "s25fl512s", INFO(0x010220, 0x4d00, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, > { "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) }, > { "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) }, > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >
On Wed, 2019-01-16 at 17:51:56 UTC, Sergei Shtylyov wrote: > Spansion S25FS512S flash is currently misdetected as S25FL512S since the > latter uses 5-byte JEDEC ID, while the 6th ID byte (family ID) is different > on those chips. Add the 6-byte S25FS512S ID before S25FL512S ID in order > not to break the existing S25FS512S users. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks. Boris
Index: linux-mtd/drivers/mtd/spi-nor/spi-nor.c =================================================================== --- linux-mtd.orig/drivers/mtd/spi-nor/spi-nor.c +++ linux-mtd/drivers/mtd/spi-nor/spi-nor.c @@ -1887,6 +1887,7 @@ static const struct flash_info spi_nor_i { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, USE_CLSR) }, { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, + { "s25fs512s", INFO6(0x010220, 0x4d0081, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, { "s25fl512s", INFO(0x010220, 0x4d00, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) }, { "s70fl01gs", INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) }, { "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024, 64, 0) },
Spansion S25FS512S flash is currently misdetected as S25FL512S since the latter uses 5-byte JEDEC ID, while the 6th ID byte (family ID) is different on those chips. Add the 6-byte S25FS512S ID before S25FL512S ID in order not to break the existing S25FS512S users. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+)