diff mbox series

SLW: Remove Idle state support tor Power8 DD1

Message ID 20190116092627.20019-1-akshay.adiga@linux.vnet.ibm.com
State Accepted
Headers show
Series SLW: Remove Idle state support tor Power8 DD1 | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master

Commit Message

Akshay Adiga Jan. 16, 2019, 9:26 a.m. UTC 
Removing init routines required for Power8 DD1, but was enabled for all
Power8 DD versions.

Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
---
 hw/slw.c | 50 --------------------------------------------------
 1 file changed, 50 deletions(-)

Comments

Stewart Smith Jan. 26, 2019, 3:20 a.m. UTC | #1 
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> writes:
> Removing init routines required for Power8 DD1, but was enabled for all
> Power8 DD versions.
>
> Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>

Thanks, merged to master as of 40b99f58ea37f8b17c0530ea9404f34d24563d9b
diff mbox series

Patch

diff --git a/hw/slw.c b/hw/slw.c
index dfa9189b..a279b5ee 100644
--- a/hw/slw.c
+++ b/hw/slw.c
@@ -219,58 +219,8 @@  static bool slw_general_init(struct proc_chip *chip, struct cpu_thread *c)
 static bool slw_set_overrides(struct proc_chip *chip, struct cpu_thread *c)
 {
 	uint32_t core = pir_to_core_id(c->pir);
-	uint64_t tmp;
 	int rc;
 
-	/*
-	 * Set ENABLE_IGNORE_RECOV_ERRORS in OHA_MODE_REG
-	 *
-	 * XXX FIXME: This should be only done for "forced" winkle such as
-	 * when doing repairs or LE transition, and we should restore the
-	 * original value when done
-	 */
-	rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX(core, PM_OHA_MODE_REG),
-			&tmp);
-	if (rc) {
-		log_simple_error(&e_info(OPAL_RC_SLW_SET),
-				"SLW: Failed to read PM_OHA_MODE_REG\n");
-		return false;
-	}
-	tmp = tmp | 0x8000000000000000ULL;
-	rc = xscom_write(chip->id, XSCOM_ADDR_P8_EX(core, PM_OHA_MODE_REG),
-			 tmp);
-	if (rc) {
-		log_simple_error(&e_info(OPAL_RC_SLW_SET),
-				"SLW: Failed to write PM_OHA_MODE_REG\n");
-		return false;
-	}
-	prlog(PR_TRACE, "SLW: PM_OHA_MODE_REG set to 0x%016llx\n", tmp);
-
-	/* Read back for debug */
-	rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX(core, PM_OHA_MODE_REG),&tmp);
-	prlog(PR_TRACE, "SLW: PM_OHA_MODE_REG read   0x%016llx\n", tmp);
-
-	/*
-	 * Clear special wakeup bits that could hold power mgt
-	 *
-	 * XXX FIXME: See above
-	 */
-	rc = xscom_write(chip->id,
-			 XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_SPECIAL_WAKEUP_FSP),
-			 0);
-	if (rc) {
-		log_simple_error(&e_info(OPAL_RC_SLW_SET),
-			"SLW: Failed to write PM_SPECIAL_WAKEUP_FSP\n");
-		return false;
-	}
-	rc = xscom_write(chip->id,
-			 XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_SPECIAL_WAKEUP_OCC),
-			 0);
-	if (rc) {
-		log_simple_error(&e_info(OPAL_RC_SLW_SET),
-			"SLW: Failed to write PM_SPECIAL_WAKEUP_OCC\n");
-		return false;
-	}
 	rc = xscom_write(chip->id,
 			 XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_SPECIAL_WAKEUP_PHYP),
 			 0);