diff mbox series

[2/3] xive: remove POWER9N DD1 NVT table size workaround

Message ID 20190116035842.4963-2-npiggin@gmail.com
State Accepted
Headers show
Series [1/3] Remove POWER9N DD1 support | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master

Commit Message

Nicholas Piggin Jan. 16, 2019, 3:58 a.m. UTC
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/xive.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Cédric Le Goater Jan. 16, 2019, 6:32 a.m. UTC | #1
On 1/16/19 4:58 AM, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  hw/xive.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/hw/xive.c b/hw/xive.c
> index dd5d12eed..05e5531cb 100644
> --- a/hw/xive.c
> +++ b/hw/xive.c
> @@ -1520,11 +1520,7 @@ static bool xive_set_vsd(struct xive *x, uint32_t tbl, uint32_t idx, uint64_t v)
>  		  SETFIELD(VST_TABLE_OFFSET, 0ull, idx));
>  	if (x->last_reg_error)
>  		return false;
> -	/* Hack to workaround DD1 issue with NVT in VC in DD1 */
> -	if (tbl == VST_TSEL_VPDT)
> -		xive_regw(x, VC_VSD_TABLE_DATA, v | VSD_TSIZE);
> -	else
> -		xive_regw(x, VC_VSD_TABLE_DATA, v);
> +	xive_regw(x, VC_VSD_TABLE_DATA, v);
>  	if (x->last_reg_error)
>  		return false;
>
diff mbox series

Patch

diff --git a/hw/xive.c b/hw/xive.c
index dd5d12eed..05e5531cb 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -1520,11 +1520,7 @@  static bool xive_set_vsd(struct xive *x, uint32_t tbl, uint32_t idx, uint64_t v)
 		  SETFIELD(VST_TABLE_OFFSET, 0ull, idx));
 	if (x->last_reg_error)
 		return false;
-	/* Hack to workaround DD1 issue with NVT in VC in DD1 */
-	if (tbl == VST_TSEL_VPDT)
-		xive_regw(x, VC_VSD_TABLE_DATA, v | VSD_TSIZE);
-	else
-		xive_regw(x, VC_VSD_TABLE_DATA, v);
+	xive_regw(x, VC_VSD_TABLE_DATA, v);
 	if (x->last_reg_error)
 		return false;