| Message ID | 20190111230129.127037-2-evgreen@chromium.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | phy: qcom-ufs: Enable regulators to be off in suspend | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, 11 Jan 2019 15:01:22 -0800, Evan Green wrote: > Add a required reset to the SDM845 UFS phy to express the PHY reset > bit inside the UFS controller register space. Before this change, this > reset was not expressed in the DT, and the driver utilized two different > callbacks (phy_init and phy_poweron) to implement a two-phase > initialization procedure that involved deasserting this reset between > init and poweron. This abused the two callbacks and diluted their > purpose. > > That scheme does not work as regulators cannot be turned off in > phy_poweroff because they were turned on in init, rather than poweron. > The net result is that regulators are left on in suspend that shouldn't > be. > > This new scheme gives the UFS reset to the PHY, so that it can fully > initialize itself in a single callback. We can then turn regulators on > during poweron and off during poweroff. > > Signed-off-by: Evan Green <evgreen@chromium.org> > --- > I realize I'm not supposed to add a required property after the fact, > but given that the UFS DT nodes that would use this binding are not > yet upstream (and this would be the first), I was hoping to squeak by. > > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt index 41a1074228ba7..6b6ca4456dc7c 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt @@ -53,7 +53,8 @@ Required properties: one for each entry in reset-names. - reset-names: "phy" for reset of phy block, "common" for phy common block reset, - "cfg" for phy's ahb cfg block reset. + "cfg" for phy's ahb cfg block reset, + "ufsphy" for the PHY reset in the UFS controller. For "qcom,ipq8074-qmp-pcie-phy" must contain: "phy", "common". @@ -65,7 +66,8 @@ Required properties: "phy", "common". For "qcom,sdm845-qmp-usb3-uni-phy" must contain: "phy", "common". - For "qcom,sdm845-qmp-ufs-phy": no resets are listed. + For "qcom,sdm845-qmp-ufs-phy": must contain: + "ufsphy". - vdda-phy-supply: Phandle to a regulator supply to PHY core block. - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.
Add a required reset to the SDM845 UFS phy to express the PHY reset bit inside the UFS controller register space. Before this change, this reset was not expressed in the DT, and the driver utilized two different callbacks (phy_init and phy_poweron) to implement a two-phase initialization procedure that involved deasserting this reset between init and poweron. This abused the two callbacks and diluted their purpose. That scheme does not work as regulators cannot be turned off in phy_poweroff because they were turned on in init, rather than poweron. The net result is that regulators are left on in suspend that shouldn't be. This new scheme gives the UFS reset to the PHY, so that it can fully initialize itself in a single callback. We can then turn regulators on during poweron and off during poweroff. Signed-off-by: Evan Green <evgreen@chromium.org> --- I realize I'm not supposed to add a required property after the fact, but given that the UFS DT nodes that would use this binding are not yet upstream (and this would be the first), I was hoping to squeak by. Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)