| Message ID | 00817c6b35b577055088a20055ce75ab6904624a.1547168645.git-series.andrew.donnellan@au1.ibm.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Support OpenCAPI and NVLink devices on same NPU on Witherspoon | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | master/apply_patch Patch failed to apply |
| snowpatch_ozlabs/apply_patch | fail | Failed to apply to any branch |
On 11/01/2019 12:09, Andrew Donnellan wrote: > We support presence detection now. Remove the TODO about that. Since when? Please add "Fixes: sha1" of the presence detection fix. > > Suggested-by: Frederic Barrat <fbarrat@linux.ibm.com> > Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > hw/npu2-opencapi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c > index 7acf3837fd40..e268b75021b1 100644 > --- a/hw/npu2-opencapi.c > +++ b/hw/npu2-opencapi.c > @@ -25,7 +25,6 @@ > * TODO: > * - Support for link ganging (one AFU using multiple links) > * - Link reset and error handling > - * - Presence detection > * - Consume HDAT NPU information > * - LPC Memory support > */ >
On 22/1/19 12:01 pm, Alexey Kardashevskiy wrote: > > > On 11/01/2019 12:09, Andrew Donnellan wrote: >> We support presence detection now. Remove the TODO about that. > > Since when? Please add "Fixes: sha1" of the presence detection fix. Done in v3 > > >> >> Suggested-by: Frederic Barrat <fbarrat@linux.ibm.com> >> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> >> --- >> hw/npu2-opencapi.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c >> index 7acf3837fd40..e268b75021b1 100644 >> --- a/hw/npu2-opencapi.c >> +++ b/hw/npu2-opencapi.c >> @@ -25,7 +25,6 @@ >> * TODO: >> * - Support for link ganging (one AFU using multiple links) >> * - Link reset and error handling >> - * - Presence detection >> * - Consume HDAT NPU information >> * - LPC Memory support >> */ >> >
diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c index 7acf3837fd40..e268b75021b1 100644 --- a/hw/npu2-opencapi.c +++ b/hw/npu2-opencapi.c @@ -25,7 +25,6 @@ * TODO: * - Support for link ganging (one AFU using multiple links) * - Link reset and error handling - * - Presence detection * - Consume HDAT NPU information * - LPC Memory support */
We support presence detection now. Remove the TODO about that. Suggested-by: Frederic Barrat <fbarrat@linux.ibm.com> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> --- hw/npu2-opencapi.c | 1 - 1 file changed, 1 deletion(-)