[ovs-dev] faq: unload kernel module when non-zero refcnt.

Message ID 1547062449-5475-1-git-send-email-u9012063@gmail.com
State Superseded
Headers show
Series
  • [ovs-dev] faq: unload kernel module when non-zero refcnt.
Related show

Commit Message

William Tu Jan. 9, 2019, 7:34 p.m.
Describe the issue about reference count and how to
drop it and unload the kernel module.

Signed-off-by: William Tu <u9012063@gmail.com>
Cc: Greg Rose <gvrose8192@gmail.com>
---
 Documentation/faq/issues.rst | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

0-day Robot Jan. 9, 2019, 8 p.m. | #1
Bleep bloop.  Greetings William Tu, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#26 FILE: Documentation/faq/issues.rst:425:
    A: The userspace might still hold the reference count. So ``rmmod openvswitch``

Lines checked: 40, Warnings: 1, Errors: 0


build:
reading sources... [ 87%] topics/ovsdb-replication
reading sources... [ 88%] topics/porting
reading sources... [ 89%] topics/role-based-access-control
reading sources... [ 90%] topics/testing
reading sources... [ 91%] topics/tracing
reading sources... [ 92%] topics/windows
reading sources... [ 92%] tutorials/faucet
reading sources... [ 93%] tutorials/index
reading sources... [ 94%] tutorials/ipsec
reading sources... [ 95%] tutorials/ovn-ipsec
reading sources... [ 96%] tutorials/ovn-openstack
reading sources... [ 97%] tutorials/ovn-rbac
reading sources... [ 98%] tutorials/ovn-sandbox
reading sources... [ 99%] tutorials/ovs-advanced
reading sources... [100%] tutorials/ovs-conntrack


Warning, treated as error:
/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/Documentation/faq/issues.rst:429: ERROR: Unexpected indentation.

make[2]: *** [docs-check] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
William Tu Jan. 9, 2019, 8:25 p.m. | #2
thanks, will fix it.

On Wed, Jan 9, 2019 at 12:02 PM 0-day Robot <robot@bytheb.org> wrote:
>
> Bleep bloop.  Greetings William Tu, I am a robot and I have tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> checkpatch:
> WARNING: Line is 83 characters long (recommended limit is 79)
> #26 FILE: Documentation/faq/issues.rst:425:
>     A: The userspace might still hold the reference count. So ``rmmod openvswitch``
>
> Lines checked: 40, Warnings: 1, Errors: 0
>
>
> build:
> reading sources... [ 87%] topics/ovsdb-replication
> reading sources... [ 88%] topics/porting
> reading sources... [ 89%] topics/role-based-access-control
> reading sources... [ 90%] topics/testing
> reading sources... [ 91%] topics/tracing
> reading sources... [ 92%] topics/windows
> reading sources... [ 92%] tutorials/faucet
> reading sources... [ 93%] tutorials/index
> reading sources... [ 94%] tutorials/ipsec
> reading sources... [ 95%] tutorials/ovn-ipsec
> reading sources... [ 96%] tutorials/ovn-openstack
> reading sources... [ 97%] tutorials/ovn-rbac
> reading sources... [ 98%] tutorials/ovn-sandbox
> reading sources... [ 99%] tutorials/ovs-advanced
> reading sources... [100%] tutorials/ovs-conntrack
>
>
> Warning, treated as error:
> /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/Documentation/faq/issues.rst:429: ERROR: Unexpected indentation.
>
> make[2]: *** [docs-check] Error 1
> make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2
>
>
> Please check this out.  If you feel there has been an error, please email aconole@bytheb.org
>
> Thanks,
> 0-day Robot
Ben Pfaff Jan. 9, 2019, 8:28 p.m. | #3
On Wed, Jan 09, 2019 at 11:34:09AM -0800, William Tu wrote:
> Describe the issue about reference count and how to
> drop it and unload the kernel module.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>
> Cc: Greg Rose <gvrose8192@gmail.com>

Thanks, applied to master.

I had to adjust indentation in one place to make the RST parser happy
when I ran "make".
William Tu Jan. 9, 2019, 8:29 p.m. | #4
On Wed, Jan 9, 2019 at 12:28 PM Ben Pfaff <blp@ovn.org> wrote:
>
> On Wed, Jan 09, 2019 at 11:34:09AM -0800, William Tu wrote:
> > Describe the issue about reference count and how to
> > drop it and unload the kernel module.
> >
> > Signed-off-by: William Tu <u9012063@gmail.com>
> > Cc: Greg Rose <gvrose8192@gmail.com>
>
> Thanks, applied to master.
>
> I had to adjust indentation in one place to make the RST parser happy
> when I ran "make".

thanks!
Then please ignore the v2.
William

Patch

diff --git a/Documentation/faq/issues.rst b/Documentation/faq/issues.rst
index 8a30dad37da0..4fd64c4c5a48 100644
--- a/Documentation/faq/issues.rst
+++ b/Documentation/faq/issues.rst
@@ -419,3 +419,17 @@  Q: I just upgraded and I see a performance drop.  Why?
 
     To get the best possible performance and functionality, it is recommended
     to pair the same versions of the kernel module and OVS userspace.
+
+Q: I can't unload the openvswitch kernel module.  Why?
+
+    A: The userspace might still hold the reference count. So ``rmmod openvswitch``
+    does not work, for example::
+
+    $ lsmod | grep openvswitch
+        openvswitch       155648 4
+        nf_conncount      24576  1 openvswitch
+
+    Use the command below to drop the refcnt::
+
+        $ ovs-dpctl del-dp system@ovs-system
+        $ rmmod openvswitch