| Message ID | 1546509899-5071-5-git-send-email-nkristam@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Tegra XUSB gadget driver support | expand |
Reviewed-by: JC Kuo <jckuo@nvidia.com> On 1/3/19 6:04 PM, Nagarjuna Kristam wrote: > Tegra210 has one XUSB device mode controller, which can be operated > HS and SS modes. Add DT support for XUSB device mode controller. > > Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > index 8fe47d6..e34a865 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > @@ -885,6 +885,23 @@ > status = "disabled"; > }; > > + xudc@700d0000 { > + compatible = "nvidia,tegra210-xudc"; > + reg = <0x0 0x700d0000 0x0 0x8000>, > + <0x0 0x700d8000 0x0 0x1000>, > + <0x0 0x700d9000 0x0 0x1000>; > + interrupts = <0 44 0x4>; > + power-domains = <&pd_xusbdev>, <&pd_xusbss>; > + power-domain-names = "xusb_device", "xusb_ss"; > + clocks = <&tegra_car TEGRA210_CLK_XUSB_DEV>, > + <&tegra_car TEGRA210_CLK_XUSB_SS>, > + <&tegra_car TEGRA210_CLK_XUSB_SSP_SRC>, > + <&tegra_car TEGRA210_CLK_XUSB_HS_SRC>, > + <&tegra_car TEGRA210_CLK_XUSB_FS_SRC>; > + nvidia,xusb-padctl = <&padctl>; > + status = "disabled"; > + }; > + > padctl: padctl@7009f000 { > compatible = "nvidia,tegra210-xusb-padctl"; > reg = <0x0 0x7009f000 0x0 0x1000>;
On Thu, Jan 03, 2019 at 03:34:55PM +0530, Nagarjuna Kristam wrote: > Tegra210 has one XUSB device mode controller, which can be operated > HS and SS modes. Add DT support for XUSB device mode controller. > > Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > index 8fe47d6..e34a865 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > @@ -885,6 +885,23 @@ > status = "disabled"; > }; > > + xudc@700d0000 { > + compatible = "nvidia,tegra210-xudc"; > + reg = <0x0 0x700d0000 0x0 0x8000>, > + <0x0 0x700d8000 0x0 0x1000>, > + <0x0 0x700d9000 0x0 0x1000>; > + interrupts = <0 44 0x4>; GIC_SPI for the first cell, IRQ_TYPE_LEVEL_HIGH for the third cell. > + power-domains = <&pd_xusbdev>, <&pd_xusbss>; > + power-domain-names = "xusb_device", "xusb_ss"; > + clocks = <&tegra_car TEGRA210_CLK_XUSB_DEV>, > + <&tegra_car TEGRA210_CLK_XUSB_SS>, > + <&tegra_car TEGRA210_CLK_XUSB_SSP_SRC>, > + <&tegra_car TEGRA210_CLK_XUSB_HS_SRC>, > + <&tegra_car TEGRA210_CLK_XUSB_FS_SRC>; I think it's slightly more idiomatic to have clocks before the power domains. Also this should have a clock-names property that names the clocks. Other than that, this looks good to me. Thierry > + nvidia,xusb-padctl = <&padctl>; > + status = "disabled"; > + }; > + > padctl: padctl@7009f000 { > compatible = "nvidia,tegra210-xusb-padctl"; > reg = <0x0 0x7009f000 0x0 0x1000>; > -- > 2.7.4 >
diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi index 8fe47d6..e34a865 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi @@ -885,6 +885,23 @@ status = "disabled"; }; + xudc@700d0000 { + compatible = "nvidia,tegra210-xudc"; + reg = <0x0 0x700d0000 0x0 0x8000>, + <0x0 0x700d8000 0x0 0x1000>, + <0x0 0x700d9000 0x0 0x1000>; + interrupts = <0 44 0x4>; + power-domains = <&pd_xusbdev>, <&pd_xusbss>; + power-domain-names = "xusb_device", "xusb_ss"; + clocks = <&tegra_car TEGRA210_CLK_XUSB_DEV>, + <&tegra_car TEGRA210_CLK_XUSB_SS>, + <&tegra_car TEGRA210_CLK_XUSB_SSP_SRC>, + <&tegra_car TEGRA210_CLK_XUSB_HS_SRC>, + <&tegra_car TEGRA210_CLK_XUSB_FS_SRC>; + nvidia,xusb-padctl = <&padctl>; + status = "disabled"; + }; + padctl: padctl@7009f000 { compatible = "nvidia,tegra210-xusb-padctl"; reg = <0x0 0x7009f000 0x0 0x1000>;
Tegra210 has one XUSB device mode controller, which can be operated HS and SS modes. Add DT support for XUSB device mode controller. Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)