[v2,11/14] imagemagick: reference explicitly fftw double

Message ID	20181212074539.11656-11-gwenj@trabucayre.com
State	Superseded
Delegated to:	Thomas Petazzoni
Headers	show Return-Path: <buildroot-bounces@busybox.net> From: Gwenhael Goavec-Merou <gwenj@trabucayre.com> To: buildroot@busybox.net Date: Wed, 12 Dec 2018 08:45:36 +0100 Message-Id: <20181212074539.11656-11-gwenj@trabucayre.com> In-Reply-To: <20181212074539.11656-1-gwenj@trabucayre.com> References: <20181212074539.11656-1-gwenj@trabucayre.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2 11/14] imagemagick: reference explicitly fftw double Precedence: list Cc: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net>
Series	[v2,01/14] fftw: breaks fftw-single into a dedicated package \| expand [v2,01/14] fftw: breaks fftw-single into a dedicated package [v2,02/14] fftw: breaks fftw-long-double into a dedicated package [v2,03/14] fftw: breaks fftw-quad into a dedicated package [v2,04/14] fftw: breaks fftw-double into a dedicated package [v2,06/14] aubio: update DEPENDENCIES to ffw-single or fftw-double depending on enabled option [v2,07/14] gnuradio: change depend to select for fftw and use fftw-single in DEPENDENCIES [v2,08/14] gqrx: suppress fft depend since fft's precision is selected by gnuradio [v2,09/14] use select instead of depend for fftw package and fix DEPENDENCIES [v2,10/14] httping: update package to use new fftw structure [v2,11/14] imagemagick: reference explicitly fftw double [v2,12/14] libvips: reference explicitly fftw double [v2,13/14] pulseaudio: update dependency to fftw-single [v2,14/14] liquid-dsp: update package to use new fftw structure

Message ID

20181212074539.11656-11-gwenj@trabucayre.com

State

Superseded

Delegated to:

Thomas Petazzoni

Headers

From: Gwenhael Goavec-Merou <gwenj@trabucayre.com>
To: buildroot@busybox.net
Date: Wed, 12 Dec 2018 08:45:36 +0100
Message-Id: <20181212074539.11656-11-gwenj@trabucayre.com>
In-Reply-To: <20181212074539.11656-1-gwenj@trabucayre.com>
References: <20181212074539.11656-1-gwenj@trabucayre.com>
MIME-Version: 1.0
Subject: [Buildroot] [PATCH v2 11/14] imagemagick: reference explicitly fftw
	double
Precedence: list
Cc: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: buildroot-bounces@busybox.net
Sender: "buildroot" <buildroot-bounces@busybox.net>

Series

[v2,01/14] fftw: breaks fftw-single into a dedicated package | expand

From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> --- package/imagemagick/imagemagick.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Joel Carlson Dec. 12, 2018, 7:34 p.m. UTC | #1

On Wed, Dec 12, 2018 at 12:45 AM Gwenhael Goavec-Merou
<gwenj@trabucayre.com> wrote:
>
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

Reviewed-by: Joel Carlson <JoelsonCarl@gmail.com>
Tested-by: Joel Carlson <JoelsonCarl@gmail.com>

Testing: compile-tested a build of imagemagick with all the
permutations of enabling/disabling fftw-single, fftw-double, and
fftw-long-double on an aarch64 build (so no fftw-quad available)

diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
index 72482267ce..7678980582 100644
--- a/package/imagemagick/imagemagick.mk
+++ b/package/imagemagick/imagemagick.mk
@@ -113,11 +113,11 @@  else
 IMAGEMAGICK_CONF_OPTS += --without-lzma
 endif
 
-ifeq ($(BR2_PACKAGE_FFTW),y)
+ifeq ($(BR2_PACKAGE_FFTW_DOUBLE),y)
 # configure script misdetects these leading to build errors
 IMAGEMAGICK_CONF_ENV += ac_cv_func_creal=yes ac_cv_func_cimag=yes
 IMAGEMAGICK_CONF_OPTS += --with-fftw
-IMAGEMAGICK_DEPENDENCIES += fftw
+IMAGEMAGICK_DEPENDENCIES += fftw-double
 else
 IMAGEMAGICK_CONF_OPTS += --without-fftw
 endif

[v2,11/14] imagemagick: reference explicitly fftw double

Commit Message

Comments

Patch