diff mbox series

[iproute2] lib/bpf: fix build warning if no elf

Message ID 20181210215110.5620-1-stephen@networkplumber.org
State Accepted, archived
Delegated to: stephen hemminger
Headers show
Series [iproute2] lib/bpf: fix build warning if no elf | expand

Commit Message

Stephen Hemminger Dec. 10, 2018, 9:51 p.m. UTC 
Function was not used unlesss HAVE_ELF causing:

bpf.c:105:13: warning: ‘bpf_map_offload_neutral’ defined but not used [-Wunused-function]

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/bpf.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Jakub Kicinski Dec. 11, 2018, 12:13 a.m. UTC | #1 
On Mon, 10 Dec 2018 13:51:11 -0800, Stephen Hemminger wrote:
> Function was not used unlesss HAVE_ELF causing:
> 
> bpf.c:105:13: warning: ‘bpf_map_offload_neutral’ defined but not used [-Wunused-function]
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Ah, FWIW:

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
diff mbox series

Patch

diff --git a/lib/bpf.c b/lib/bpf.c
index 6aff8f7bad7f..5e85cfc0bdd5 100644
--- a/lib/bpf.c
+++ b/lib/bpf.c
@@ -102,11 +102,6 @@  static const struct bpf_prog_meta __bpf_prog_meta[] = {
 	},
 };
 
-static bool bpf_map_offload_neutral(enum bpf_map_type type)
-{
-	return type == BPF_MAP_TYPE_PERF_EVENT_ARRAY;
-}
-
 static const char *bpf_prog_to_subdir(enum bpf_prog_type type)
 {
 	assert(type < ARRAY_SIZE(__bpf_prog_meta) &&
@@ -1610,6 +1605,11 @@  static bool bpf_is_map_in_map_type(const struct bpf_elf_map *map)
 	       map->type == BPF_MAP_TYPE_HASH_OF_MAPS;
 }
 
+static bool bpf_map_offload_neutral(enum bpf_map_type type)
+{
+	return type == BPF_MAP_TYPE_PERF_EVENT_ARRAY;
+}
+
 static int bpf_map_attach(const char *name, struct bpf_elf_ctx *ctx,
 			  const struct bpf_elf_map *map, struct bpf_map_ext *ext,
 			  int *have_map_in_map)