[ovs-dev,v1] rhel: Add 'SYSTEMD_NO_WRAP=yes' in ovs init script for SLES
diff mbox series

Message ID 20181210143319.29694-1-martinxu9.ovs@gmail.com
State New
Headers show
Series
  • [ovs-dev,v1] rhel: Add 'SYSTEMD_NO_WRAP=yes' in ovs init script for SLES
Related show

Commit Message

Martin Xu Dec. 10, 2018, 2:33 p.m. UTC
The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES
12 is 'SYSTEMD_NO_WRAP=yes'

VMware-BZ: #2245358
Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
CC: Markos Chandras <mchandras@suse.de>
CC: Ansis Atteka <aatteka@ovn.org>
CC: Ben Pfaff <blp@ovn.org>
---
 rhel/etc_init.d_openvswitch | 1 +
 1 file changed, 1 insertion(+)

Comments

Ben Pfaff Dec. 12, 2018, 7:53 p.m. UTC | #1
On Mon, Dec 10, 2018 at 06:33:19AM -0800, Martin Xu wrote:
> The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES
> 12 is 'SYSTEMD_NO_WRAP=yes'
> 
> VMware-BZ: #2245358
> Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
> CC: Markos Chandras <mchandras@suse.de>
> CC: Ansis Atteka <aatteka@ovn.org>
> CC: Ben Pfaff <blp@ovn.org>

Markos, for this patch, I'm hoping to see a review from you or someone
else who knows SuSE well.
Markos Chandras Dec. 13, 2018, 9:29 a.m. UTC | #2
Hello,

On 10/12/2018 14:33, Martin Xu wrote:
> The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES
> 12 is 'SYSTEMD_NO_WRAP=yes'
> 
> VMware-BZ: #2245358
> Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
> CC: Markos Chandras <mchandras@suse.de>
> CC: Ansis Atteka <aatteka@ovn.org>
> CC: Ben Pfaff <blp@ovn.org>
> ---
>  rhel/etc_init.d_openvswitch | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_openvswitch
> index 20d556803..7a4cfbab5 100755
> --- a/rhel/etc_init.d_openvswitch
> +++ b/rhel/etc_init.d_openvswitch
> @@ -28,6 +28,7 @@
>  ### END INIT INFO
>  
>  SYSTEMCTL_SKIP_REDIRECT=yes
> +SYSTEMD_NO_WRAP=yes
>  
>  . /usr/share/openvswitch/scripts/ovs-lib || exit 1
>  test -e /etc/sysconfig/openvswitch && . /etc/sysconfig/openvswitch
> 

Looks good to me. Thank you

Reviewed-by: Markos Chandras <mchandras@suse.de>
Ben Pfaff Dec. 13, 2018, 7:29 p.m. UTC | #3
On Thu, Dec 13, 2018 at 09:29:39AM +0000, Markos Chandras wrote:
> Hello,
> 
> On 10/12/2018 14:33, Martin Xu wrote:
> > The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES
> > 12 is 'SYSTEMD_NO_WRAP=yes'
> > 
> > VMware-BZ: #2245358
> > Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com>
> > CC: Markos Chandras <mchandras@suse.de>
> > CC: Ansis Atteka <aatteka@ovn.org>
> > CC: Ben Pfaff <blp@ovn.org>
> > ---
> >  rhel/etc_init.d_openvswitch | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_openvswitch
> > index 20d556803..7a4cfbab5 100755
> > --- a/rhel/etc_init.d_openvswitch
> > +++ b/rhel/etc_init.d_openvswitch
> > @@ -28,6 +28,7 @@
> >  ### END INIT INFO
> >  
> >  SYSTEMCTL_SKIP_REDIRECT=yes
> > +SYSTEMD_NO_WRAP=yes
> >  
> >  . /usr/share/openvswitch/scripts/ovs-lib || exit 1
> >  test -e /etc/sysconfig/openvswitch && . /etc/sysconfig/openvswitch
> > 
> 
> Looks good to me. Thank you
> 
> Reviewed-by: Markos Chandras <mchandras@suse.de>

Applied to master, backported as far as branch-2.6.  Thanks Martin and
Markos!

Patch
diff mbox series

diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_openvswitch
index 20d556803..7a4cfbab5 100755
--- a/rhel/etc_init.d_openvswitch
+++ b/rhel/etc_init.d_openvswitch
@@ -28,6 +28,7 @@ 
 ### END INIT INFO
 
 SYSTEMCTL_SKIP_REDIRECT=yes
+SYSTEMD_NO_WRAP=yes
 
 . /usr/share/openvswitch/scripts/ovs-lib || exit 1
 test -e /etc/sysconfig/openvswitch && . /etc/sysconfig/openvswitch