qmi_wwan: Added support for Fibocom NL668 series

Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>

drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

Jörgen Storvist <jorgen.storvist@gmail.com> writes:

> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
>
> drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..820081e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
>  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
>  
>  	/* 4. Gobi 1000 devices */
>  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

Looks good, but could you please try to add it in a semi-numeric order?
Yes, I know it's far from perfect from before.  But I'm hoping to avoid
it growing worse ;-)


Bjørn

Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com> 
---
Changes:
Changed list order to correpond to USB VID/PID values. 

drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 72a55b6..dada68f 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd191, 4)},	/* Wistron NeWeb D19Q1 */
+	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
 	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
 	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
 	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */

Thanks for the feedback Björn! 
Should be correct now as above if I understood you correctly.
//Jörgen

Den Mon, 10 Dec 2018 14:52:35 +0100
skrev Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series:

> Jörgen Storvist <jorgen.storvist@gmail.com> writes:
> 
> > Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> > Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
> >
> > Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
> >
> > drivers/net/usb/qmi_wwan.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 72a55b6..820081e 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
> >  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
> >  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
> >  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> > +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
> >  
> >  	/* 4. Gobi 1000 devices */
> >  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */  
> 
> Looks good, but could you please try to add it in a semi-numeric order?
> Yes, I know it's far from perfect from before.  But I'm hoping to avoid
> it growing worse ;-)
> 
> 
> Bjørn

Jörgen Storvist <jorgen.storvist@gmail.com> writes:

> Should be correct now as above if I understood you correctly.

Yup, the sorting part looks fine.  But you need to drop the additional
text below the patch. It will mess up the result.  Any extra text which
isn't part of the patch or the commit message should go inside the ---
markers, like you correctly did with the changelog.

It's also possible to use "scissors" to separate extra text from the
patch, but this is rarely used. Ref https://kernelnewbies.org/PatchTipsAndTricks



Bjørn