diff mbox series

[v2,2/3] system cfg: set mkpasswd default to SHA256

Message ID 1544061989-7450-2-git-send-email-matthew.weber@rockwellcollins.com
State Accepted
Commit 9cf2280846b60ba081ed21339b407e2c761b599d
Headers show
Series [v2,1/3] system cfg: update mkpasswd SHA option txt | expand

Commit Message

Matt Weber Dec. 6, 2018, 2:06 a.m. UTC 
This patch changes the default mkpasswd method to SHA256 from MD5.
The change both improves the quality of the hash used and prepares
for eventually removing MD5 as a option.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
Changes
v2 - New patch
---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Dec. 15, 2018, 10:27 a.m. UTC | #1 
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > This patch changes the default mkpasswd method to SHA256 from MD5.
 > The change both improves the quality of the hash used and prepares
 > for eventually removing MD5 as a option.

 > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
 > ---
 > Changes
 > v2 - New patch

Changing defaults is always tricky, but considering that the next
release will become LTS I think it will be OK.

Committed, thanks.
diff mbox series

Patch

diff --git a/system/Config.in b/system/Config.in
index e33568f..65c92a8 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -61,7 +61,7 @@  endif
 
 choice
 	bool "Passwords encoding"
-	default BR2_TARGET_GENERIC_PASSWD_MD5
+	default BR2_TARGET_GENERIC_PASSWD_SHA256
 	help
 	  Choose the password encoding scheme to use when Buildroot
 	  needs to encode a password (eg. the root password, below).