| Message ID | 20181203144743.5p6ve64mw32y67oy@kili.mountain |
|---|---|
| State | Superseded |
| Delegated to: | Richard Weinberger |
| Headers | show |
| Series | ubifs: fix a memory leak in ubifs_lpt_calc_hash() | expand |
Hi Dan, On Mon, Dec 03, 2018 at 05:47:43PM +0300, Dan Carpenter wrote: > We need to free a couple memory allocations before returning on this > error path. Indeed, good catch. Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha > > Fixes: a1dc58140f7e ("ubifs: authentication: Authenticate LPT") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > fs/ubifs/lpt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c > index d1d5e96350dd..c162459a1e02 100644 > --- a/fs/ubifs/lpt.c > +++ b/fs/ubifs/lpt.c > @@ -1688,7 +1688,7 @@ int ubifs_lpt_calc_hash(struct ubifs_info *c, u8 *hash) > if (!c->nroot) { > err = ubifs_read_nnode(c, NULL, 0); > if (err) > - return err; > + goto out; > } > > cnode = (struct ubifs_cnode *)c->nroot; > -- > 2.11.0 > >
diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c index d1d5e96350dd..c162459a1e02 100644 --- a/fs/ubifs/lpt.c +++ b/fs/ubifs/lpt.c @@ -1688,7 +1688,7 @@ int ubifs_lpt_calc_hash(struct ubifs_info *c, u8 *hash) if (!c->nroot) { err = ubifs_read_nnode(c, NULL, 0); if (err) - return err; + goto out; } cnode = (struct ubifs_cnode *)c->nroot;
We need to free a couple memory allocations before returning on this error path. Fixes: a1dc58140f7e ("ubifs: authentication: Authenticate LPT") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/ubifs/lpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)