mbox series

[bpf-next,0/4] samples: bpf: convert two more samples to libbpf

Message ID 20180726213221.1295-1-jakub.kicinski@netronome.com
Headers show
Series samples: bpf: convert two more samples to libbpf | expand

Message

Jakub Kicinski July 26, 2018, 9:32 p.m. UTC
Hi!

This set converts xdpsock_user.c and xdp_fwd_user.c to use libbpf instead
of bpf_load.o.  First two patches are minor improvements to libbpf to make
the conversion (and use of libbpf in general) nicer.

Jakub Kicinski (4):
  tools: libbpf: handle NULL program gracefully in bpf_program__nth_fd()
  tools: libbpf: add bpf_object__find_program_by_title()
  samples: bpf: convert xdp_fwd_user.c to libbpf
  samples: bpf: convert xdpsock_user.c to libbpf

 samples/bpf/Makefile       |  4 ++--
 samples/bpf/xdp_fwd_user.c | 34 +++++++++++++++++++++++-----------
 samples/bpf/xdpsock_user.c | 38 +++++++++++++++++++++++++++++---------
 tools/lib/bpf/libbpf.c     | 15 +++++++++++++++
 tools/lib/bpf/libbpf.h     |  3 +++
 5 files changed, 72 insertions(+), 22 deletions(-)

Comments

Y Song July 26, 2018, 11:57 p.m. UTC | #1
On Thu, Jul 26, 2018 at 2:32 PM, Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
> Hi!
>
> This set converts xdpsock_user.c and xdp_fwd_user.c to use libbpf instead
> of bpf_load.o.  First two patches are minor improvements to libbpf to make
> the conversion (and use of libbpf in general) nicer.
>
> Jakub Kicinski (4):
>   tools: libbpf: handle NULL program gracefully in bpf_program__nth_fd()
>   tools: libbpf: add bpf_object__find_program_by_title()
>   samples: bpf: convert xdp_fwd_user.c to libbpf
>   samples: bpf: convert xdpsock_user.c to libbpf

LGTM. Ack for the whole series.
Acked-by: Yonghong Song <yhs@fb.com>

>
>  samples/bpf/Makefile       |  4 ++--
>  samples/bpf/xdp_fwd_user.c | 34 +++++++++++++++++++++++-----------
>  samples/bpf/xdpsock_user.c | 38 +++++++++++++++++++++++++++++---------
>  tools/lib/bpf/libbpf.c     | 15 +++++++++++++++
>  tools/lib/bpf/libbpf.h     |  3 +++
>  5 files changed, 72 insertions(+), 22 deletions(-)
>
> --
> 2.17.1
>
Daniel Borkmann July 27, 2018, 5:21 a.m. UTC | #2
On 07/26/2018 11:32 PM, Jakub Kicinski wrote:
> Hi!
> 
> This set converts xdpsock_user.c and xdp_fwd_user.c to use libbpf instead
> of bpf_load.o.  First two patches are minor improvements to libbpf to make
> the conversion (and use of libbpf in general) nicer.
> 
> Jakub Kicinski (4):
>   tools: libbpf: handle NULL program gracefully in bpf_program__nth_fd()
>   tools: libbpf: add bpf_object__find_program_by_title()
>   samples: bpf: convert xdp_fwd_user.c to libbpf
>   samples: bpf: convert xdpsock_user.c to libbpf
> 
>  samples/bpf/Makefile       |  4 ++--
>  samples/bpf/xdp_fwd_user.c | 34 +++++++++++++++++++++++-----------
>  samples/bpf/xdpsock_user.c | 38 +++++++++++++++++++++++++++++---------
>  tools/lib/bpf/libbpf.c     | 15 +++++++++++++++
>  tools/lib/bpf/libbpf.h     |  3 +++
>  5 files changed, 72 insertions(+), 22 deletions(-)
> 

Applied to bpf-next, thanks Jakub!