From patchwork Sat Nov 11 06:19:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lawrence Brakmo X-Patchwork-Id: 836997 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fb.com header.i=@fb.com header.b="buM+fIvq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yYmws33Dgz9sRW for ; Sat, 11 Nov 2017 17:20:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbdKKGUX (ORCPT ); Sat, 11 Nov 2017 01:20:23 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:46164 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751334AbdKKGUA (ORCPT ); Sat, 11 Nov 2017 01:20:00 -0500 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.16.0.21/8.16.0.21) with SMTP id vAB6GVj7032296 for ; Fri, 10 Nov 2017 22:20:00 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=facebook; bh=Pre1I3J/xMu3cXlKA4NbKCjhbq0lFhJ1l+k2Jqbtxwk=; b=buM+fIvqiA6JvHIG9NzBD7FFdOokbAMKEJs/5d3O5x7LKZrqM4TVt/f7CKYVVy1pZIe+ u8lP70BO/jtHbJTPJGDxVxidWTRuL4mbcYM+QPeuA2eLYCugH+7XojupiRG38yl8vg7K uqLrWAOrCHlZAh3vcZ0TtOEAoDUEyShDJZ4= Received: from mail.thefacebook.com ([199.201.64.23]) by m0001303.ppops.net with ESMTP id 2e5u0vg47t-2 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 10 Nov 2017 22:20:00 -0800 Received: from mx-out.facebook.com (192.168.52.123) by PRN-CHUB03.TheFacebook.com (192.168.16.13) with Microsoft SMTP Server id 14.3.361.1; Fri, 10 Nov 2017 22:19:57 -0800 Received: by dev15893.prn1.facebook.com (Postfix, from userid 10340) id 04379C24630; Fri, 10 Nov 2017 22:19:57 -0800 (PST) Smtp-Origin-Hostprefix: dev From: Lawrence Brakmo Smtp-Origin-Hostname: dev15893.prn1.facebook.com To: netdev CC: Alexei Starovoitov , Daniel Borkmann Smtp-Origin-Cluster: prn1c29 Subject: [PATCH net-next v2 0/6] bpf: Fix bugs in sock_ops samples Date: Fri, 10 Nov 2017 22:19:49 -0800 Message-ID: <20171111061955.615775-1-brakmo@fb.com> X-Mailer: git-send-email 2.9.5 X-FB-Internal: Safe MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-11-11_02:, , signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The programs were returning -1 in some cases when they should only return 0 or 1. Changes in the verifier now catch this issue and the programs fail to load. This is now fixed. [PATCH net-next v2 1/6] bpf: Fix tcp_synrto_kern.c sample program [PATCH net-next v2 2/6] bpf: Fix tcp_rwnd_kern.c sample program [PATCH net-next v2 3/6] bpf: Fix tcp_bufs_kern.c sample program [PATCH net-next v2 4/6] bpf: Fix tcp_cong_kern.c sample program [PATCH net-next v2 5/6] bpf: Fix tcp_iw_kern.c sample program [PATCH net-next v2 6/6] bpf: Fix tcp_clamp_kern.c sample program samples/bpf/tcp_bufs_kern.c | 14 ++++++++------ samples/bpf/tcp_clamp_kern.c | 24 +++++++++++++----------- samples/bpf/tcp_cong_kern.c | 6 ++++-- samples/bpf/tcp_iw_kern.c | 14 ++++++++------ samples/bpf/tcp_rwnd_kern.c | 6 ++++-- samples/bpf/tcp_synrto_kern.c | 6 ++++-- files changed, 41 insertions(+), 29 deletions(-)