| Message ID | 20191112164634.7712.40697.stgit@dceara.remote.csb |
|---|---|
| Headers | show |
| Series | Improve ovn-detrace support for parsing OpenFlow cookies. | expand |
For the series: Acked-by: Mark Michelson <mmichels@redhat.com> On 11/12/19 11:47 AM, Dumitru Ceara wrote: > Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") > added support for more types of cookies (partial SB uuids) that are stored > in OpenFlow entries created by ovn-controller. > > The last patch in this series implements support for parsing all these > different cookies in ovn-detrace too. > > The first patch is a bug fix required as ovn-detrace was broken after > moving OVN to its own separate rundir. > > The second patch fixes line parsing in ovn-detrace. > > CC: Han Zhou <hzhou@ovn.org> > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > > Dumitru Ceara (3): > ovn-detrace: Fix rundir. > ovn-detrace: Fix line parsing. > ovn-detrace: Add support for other types of SB cookies. > > > utilities/ovn-detrace.in | 215 +++++++++++++++++++++++++++++++--------------- > 1 file changed, 146 insertions(+), 69 deletions(-) > > > --- > v3: > - Remove stray "%s". > - Rename pprint to print_p to avoid name clashes with the library function. > v2: > - Address Mark's comments: > - properly handle potential collisions between cookie -> UUID mappings. > - when looking up SB records by cookie, match on the first part of the > UUID. > - Further refactor ovn-detrace to simplify prefixing outputs. > - Change print statements to print() calls. >
On Tue, Nov 12, 2019 at 8:47 AM Dumitru Ceara <dceara@redhat.com> wrote: > > Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") > added support for more types of cookies (partial SB uuids) that are stored > in OpenFlow entries created by ovn-controller. > > The last patch in this series implements support for parsing all these > different cookies in ovn-detrace too. > > The first patch is a bug fix required as ovn-detrace was broken after > moving OVN to its own separate rundir. > > The second patch fixes line parsing in ovn-detrace. > > CC: Han Zhou <hzhou@ovn.org> > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > > Dumitru Ceara (3): > ovn-detrace: Fix rundir. > ovn-detrace: Fix line parsing. > ovn-detrace: Add support for other types of SB cookies. > > > utilities/ovn-detrace.in | 215 +++++++++++++++++++++++++++++++--------------- > 1 file changed, 146 insertions(+), 69 deletions(-) > > > --- > v3: > - Remove stray "%s". > - Rename pprint to print_p to avoid name clashes with the library function. > v2: > - Address Mark's comments: > - properly handle potential collisions between cookie -> UUID mappings. > - when looking up SB records by cookie, match on the first part of the > UUID. > - Further refactor ovn-detrace to simplify prefixing outputs. > - Change print statements to print() calls. > Thanks Dumitru for improving the tool! Patch 1 and 3 look good to me. I posted comments for patch 2. Thanks, Han
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added support for more types of cookies (partial SB uuids) that are stored in OpenFlow entries created by ovn-controller. The last patch in this series implements support for parsing all these different cookies in ovn-detrace too. The first patch is a bug fix required as ovn-detrace was broken after moving OVN to its own separate rundir. The second patch fixes line parsing in ovn-detrace. CC: Han Zhou <hzhou@ovn.org> Signed-off-by: Dumitru Ceara <dceara@redhat.com> Dumitru Ceara (3): ovn-detrace: Fix rundir. ovn-detrace: Fix line parsing. ovn-detrace: Add support for other types of SB cookies. utilities/ovn-detrace.in | 215 +++++++++++++++++++++++++++++++--------------- 1 file changed, 146 insertions(+), 69 deletions(-) --- v3: - Remove stray "%s". - Rename pprint to print_p to avoid name clashes with the library function. v2: - Address Mark's comments: - properly handle potential collisions between cookie -> UUID mappings. - when looking up SB records by cookie, match on the first part of the UUID. - Further refactor ovn-detrace to simplify prefixing outputs. - Change print statements to print() calls.