mbox series

[ovs-dev,v5,ovn,0/3] Add rate limiting support for controller_events

Message ID cover.1567519564.git.lorenzo.bianconi@redhat.com
Headers show
Series Add rate limiting support for controller_events | expand

Message

Lorenzo Bianconi Sept. 3, 2019, 2:22 p.m. UTC 
Introduce the capability to associate a meter to each controller event
type in order to not overload the pinctrl thread under heavy load.
For each event type we need to define a naming convention for the related
meter:
- empty_lb_backends: event-elb

Changes since v4:
- rebase ontop of current ovn master branch
- fold patch 1/3: northd: introduce build_empty_lb_event_flow routine
Changes since v3:
- rebase on top of 'add empty_lb controller_event for logical router pipeline'
  https://patchwork.ozlabs.org/cover/1153918/
- update documentation
- added a unit test for the meter option in the "action parsing"
Changes since v2:
- fold patch 'Repair memory leak for OVN controller events'
- fix memory leak of meter string
Changes since v1:
- fix subject

Lorenzo Bianconi (3):
  northd: introduce build_empty_lb_event_flow routine
  add meter support to trigger_event action
  northd: add rate limiting support for SB controller events

 include/ovn/actions.h   |   1 +
 lib/actions.c           |  43 ++++++++++++++---
 northd/ovn-northd.8.xml |   5 ++
 northd/ovn-northd.c     | 102 +++++++++++++++++++++++++++-------------
 ovn-nb.xml              |   8 ++++
 ovn-sb.xml              |   5 +-
 tests/ovn.at            |   5 ++
 7 files changed, 130 insertions(+), 39 deletions(-)

Comments

Mark Michelson Sept. 6, 2019, 12:43 p.m. UTC | #1 
Looks good, Lorenzo.

Acked-by: Mark Michelson <mmichels@redhat.com>

On 9/3/19 10:22 AM, Lorenzo Bianconi wrote:
> Introduce the capability to associate a meter to each controller event
> type in order to not overload the pinctrl thread under heavy load.
> For each event type we need to define a naming convention for the related
> meter:
> - empty_lb_backends: event-elb
> 
> Changes since v4:
> - rebase ontop of current ovn master branch
> - fold patch 1/3: northd: introduce build_empty_lb_event_flow routine
> Changes since v3:
> - rebase on top of 'add empty_lb controller_event for logical router pipeline'
>    https://patchwork.ozlabs.org/cover/1153918/
> - update documentation
> - added a unit test for the meter option in the "action parsing"
> Changes since v2:
> - fold patch 'Repair memory leak for OVN controller events'
> - fix memory leak of meter string
> Changes since v1:
> - fix subject
> 
> Lorenzo Bianconi (3):
>    northd: introduce build_empty_lb_event_flow routine
>    add meter support to trigger_event action
>    northd: add rate limiting support for SB controller events
> 
>   include/ovn/actions.h   |   1 +
>   lib/actions.c           |  43 ++++++++++++++---
>   northd/ovn-northd.8.xml |   5 ++
>   northd/ovn-northd.c     | 102 +++++++++++++++++++++++++++-------------
>   ovn-nb.xml              |   8 ++++
>   ovn-sb.xml              |   5 +-
>   tests/ovn.at            |   5 ++
>   7 files changed, 130 insertions(+), 39 deletions(-)
>
Mark Michelson Sept. 6, 2019, 2:08 p.m. UTC | #2 
I pushed this series to master.

On 9/3/19 10:22 AM, Lorenzo Bianconi wrote:
> Introduce the capability to associate a meter to each controller event
> type in order to not overload the pinctrl thread under heavy load.
> For each event type we need to define a naming convention for the related
> meter:
> - empty_lb_backends: event-elb
> 
> Changes since v4:
> - rebase ontop of current ovn master branch
> - fold patch 1/3: northd: introduce build_empty_lb_event_flow routine
> Changes since v3:
> - rebase on top of 'add empty_lb controller_event for logical router pipeline'
>    https://patchwork.ozlabs.org/cover/1153918/
> - update documentation
> - added a unit test for the meter option in the "action parsing"
> Changes since v2:
> - fold patch 'Repair memory leak for OVN controller events'
> - fix memory leak of meter string
> Changes since v1:
> - fix subject
> 
> Lorenzo Bianconi (3):
>    northd: introduce build_empty_lb_event_flow routine
>    add meter support to trigger_event action
>    northd: add rate limiting support for SB controller events
> 
>   include/ovn/actions.h   |   1 +
>   lib/actions.c           |  43 ++++++++++++++---
>   northd/ovn-northd.8.xml |   5 ++
>   northd/ovn-northd.c     | 102 +++++++++++++++++++++++++++-------------
>   ovn-nb.xml              |   8 ++++
>   ovn-sb.xml              |   5 +-
>   tests/ovn.at            |   5 ++
>   7 files changed, 130 insertions(+), 39 deletions(-)
>