[v8,0/6] Patch series to support Thunderbolt without any BIOS support
mbox series

Message ID SL2P216MB01873757CFAE0E4B02F1BBE080C00@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM
Headers show
Series
  • Patch series to support Thunderbolt without any BIOS support
Related show

Message

Nicholas Johnson July 26, 2019, 12:52 p.m. UTC
Patch series rebased to 5.3-rc1.

If possible, please have a quick read over while I am away (2019-07-27
to mid 2019-08-04), so I can fix any mistakes or make simple changes to
get problems out of the way for a more thorough examination later.

Thanks!

Kind regards,
Nicholas

Nicholas Johnson (6):
  PCI: Consider alignment of hot-added bridges when distributing
    available resources
  PCI: In extend_bridge_window() change available to new_size
  PCI: Change extend_bridge_window() to set resource size directly
  PCI: Allow extend_bridge_window() to shrink resource if necessary
  PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
  PCI: Fix bug resulting in double hpmemsize being assigned to MMIO
    window

 .../admin-guide/kernel-parameters.txt         |   9 +-
 drivers/pci/pci.c                             |  17 +-
 drivers/pci/setup-bus.c                       | 233 +++++++++---------
 include/linux/pci.h                           |   3 +-
 4 files changed, 143 insertions(+), 119 deletions(-)

Comments

Mika Westerberg Oct. 3, 2019, 12:19 p.m. UTC | #1
On Fri, Jul 26, 2019 at 12:52:58PM +0000, Nicholas Johnson wrote:
> Patch series rebased to 5.3-rc1.
> 
> If possible, please have a quick read over while I am away (2019-07-27
> to mid 2019-08-04), so I can fix any mistakes or make simple changes to
> get problems out of the way for a more thorough examination later.
> 
> Thanks!
> 
> Kind regards,
> Nicholas
> 
> Nicholas Johnson (6):
>   PCI: Consider alignment of hot-added bridges when distributing
>     available resources
>   PCI: In extend_bridge_window() change available to new_size
>   PCI: Change extend_bridge_window() to set resource size directly
>   PCI: Allow extend_bridge_window() to shrink resource if necessary
>   PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
>   PCI: Fix bug resulting in double hpmemsize being assigned to MMIO
>     window

Hi Bjorn,

What's the status of this series? I don't see them in v5.4-rc1.

Thanks!
Bjorn Helgaas Oct. 4, 2019, 1:08 p.m. UTC | #2
On Thu, Oct 03, 2019 at 03:19:46PM +0300, mika.westerberg@linux.intel.com wrote:
> On Fri, Jul 26, 2019 at 12:52:58PM +0000, Nicholas Johnson wrote:
> > Patch series rebased to 5.3-rc1.
> > 
> > If possible, please have a quick read over while I am away (2019-07-27
> > to mid 2019-08-04), so I can fix any mistakes or make simple changes to
> > get problems out of the way for a more thorough examination later.
> > 
> > Thanks!
> > 
> > Kind regards,
> > Nicholas
> > 
> > Nicholas Johnson (6):
> >   PCI: Consider alignment of hot-added bridges when distributing
> >     available resources
> >   PCI: In extend_bridge_window() change available to new_size
> >   PCI: Change extend_bridge_window() to set resource size directly
> >   PCI: Allow extend_bridge_window() to shrink resource if necessary
> >   PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
> >   PCI: Fix bug resulting in double hpmemsize being assigned to MMIO
> >     window
> 
> Hi Bjorn,
> 
> What's the status of this series? I don't see them in v5.4-rc1.

They're still on my to-do list but are currently languishing because
they touch critical but complicated code that I don't understand and
nobody else has chimed in to help review them.  Testing reports would
also be helpful.

It's been a long time since I've looked at these, but I wonder if at
least the incremental step of adding the parameter to set the
MMIO_PREF size separately from the MMIO size would be more
approachable.

Bjorn
Mika Westerberg Oct. 4, 2019, 3 p.m. UTC | #3
On Fri, Oct 04, 2019 at 08:08:03AM -0500, Bjorn Helgaas wrote:
> On Thu, Oct 03, 2019 at 03:19:46PM +0300, mika.westerberg@linux.intel.com wrote:
> > On Fri, Jul 26, 2019 at 12:52:58PM +0000, Nicholas Johnson wrote:
> > > Patch series rebased to 5.3-rc1.
> > > 
> > > If possible, please have a quick read over while I am away (2019-07-27
> > > to mid 2019-08-04), so I can fix any mistakes or make simple changes to
> > > get problems out of the way for a more thorough examination later.
> > > 
> > > Thanks!
> > > 
> > > Kind regards,
> > > Nicholas
> > > 
> > > Nicholas Johnson (6):
> > >   PCI: Consider alignment of hot-added bridges when distributing
> > >     available resources
> > >   PCI: In extend_bridge_window() change available to new_size
> > >   PCI: Change extend_bridge_window() to set resource size directly
> > >   PCI: Allow extend_bridge_window() to shrink resource if necessary
> > >   PCI: Add hp_mmio_size and hp_mmio_pref_size parameters
> > >   PCI: Fix bug resulting in double hpmemsize being assigned to MMIO
> > >     window
> > 
> > Hi Bjorn,
> > 
> > What's the status of this series? I don't see them in v5.4-rc1.
> 
> They're still on my to-do list but are currently languishing because
> they touch critical but complicated code that I don't understand and
> nobody else has chimed in to help review them.  Testing reports would
> also be helpful.

I will test this next week as it solves one issue I reported some time ago.

I can also help you to review this, at least parts touching
extend_bridge_window() and pci_bus_distribute_available_resources(),
because those functions were added by me ;-)