[ovs-dev,0/3] be able to tune revalidator timing
mbox series

Message ID 1563698063-28256-1-git-send-email-roid@mellanox.com
Headers show
Series
  • be able to tune revalidator timing
Related show

Message

Roi Dayan July 21, 2019, 8:34 a.m. UTC
Hi,

The following series expose configuration options to
be able to tune revalidator timing to different setups
at runtime instead of using hard coded values.

Thanks,
Roi


Vlad Buslov (3):
  upcall: Configure datapath max-revalidator through ovs-vsctl.
  upcall: Change should_revalidate to use max-revalidator value
  upcall: Configure datapath min-revalidate-pps through ovs-vsctl.

 ofproto/ofproto-dpif-upcall.c |  9 +++++----
 ofproto/ofproto-provider.h    |  8 ++++++++
 ofproto/ofproto.c             | 19 +++++++++++++++++++
 ofproto/ofproto.h             |  4 ++++
 vswitchd/bridge.c             |  6 ++++++
 vswitchd/vswitch.xml          | 25 +++++++++++++++++++++++++
 6 files changed, 67 insertions(+), 4 deletions(-)

Comments

Ben Pfaff July 22, 2019, 5:10 p.m. UTC | #1
On Sun, Jul 21, 2019 at 11:34:20AM +0300, Roi Dayan wrote:
> The following series expose configuration options to
> be able to tune revalidator timing to different setups
> at runtime instead of using hard coded values.

These seem fine.

I'd like to wait until we've branched for 2.12 before applying them.
Roi Dayan Aug. 6, 2019, 4:49 a.m. UTC | #2
On 2019-07-22 8:10 PM, Ben Pfaff wrote:
> On Sun, Jul 21, 2019 at 11:34:20AM +0300, Roi Dayan wrote:
>> The following series expose configuration options to
>> be able to tune revalidator timing to different setups
>> at runtime instead of using hard coded values.
> 
> These seem fine.
> 
> I'd like to wait until we've branched for 2.12 before applying them.
> 

Hi Ben,

I see there is now a branch for 2.12.
can you take these commits now?

Thanks,
Roi
Roi Dayan Aug. 15, 2019, 10:52 a.m. UTC | #3
On 2019-08-06 7:49 AM, Roi Dayan wrote:
> 
> 
> On 2019-07-22 8:10 PM, Ben Pfaff wrote:
>> On Sun, Jul 21, 2019 at 11:34:20AM +0300, Roi Dayan wrote:
>>> The following series expose configuration options to
>>> be able to tune revalidator timing to different setups
>>> at runtime instead of using hard coded values.
>>
>> These seem fine.
>>
>> I'd like to wait until we've branched for 2.12 before applying them.
>>
> 
> Hi Ben,
> 
> I see there is now a branch for 2.12.
> can you take these commits now?
> 
> Thanks,
> Roi
> 

Hi,

just pinging here.

Thanks,
Roi
Ben Pfaff Aug. 21, 2019, 10:42 p.m. UTC | #4
On Thu, Aug 15, 2019 at 10:52:53AM +0000, Roi Dayan wrote:
> 
> 
> On 2019-08-06 7:49 AM, Roi Dayan wrote:
> > 
> > 
> > On 2019-07-22 8:10 PM, Ben Pfaff wrote:
> >> On Sun, Jul 21, 2019 at 11:34:20AM +0300, Roi Dayan wrote:
> >>> The following series expose configuration options to
> >>> be able to tune revalidator timing to different setups
> >>> at runtime instead of using hard coded values.
> >>
> >> These seem fine.
> >>
> >> I'd like to wait until we've branched for 2.12 before applying them.
> >>
> > 
> > Hi Ben,
> > 
> > I see there is now a branch for 2.12.
> > can you take these commits now?
> > 
> > Thanks,
> > Roi
> > 
> 
> Hi,
> 
> just pinging here.

Finally got around to it.  Sorry about the delay.