[v3,0/2] Fix a pair of setup bus bugs
mbox series

Message ID 20190531171216.20532-1-logang@deltatee.com
Headers show
Series
  • Fix a pair of setup bus bugs
Related show

Message

Logan Gunthorpe May 31, 2019, 5:12 p.m. UTC
Hey,

This is another resend to get some more attention. Nothing has changed
since v2.

For the first patch, there's a lot more information in the original
thread here[1] including instructions on how to reproduce it in QEMU.

The second patch fixes an unrelated bug, with similar symptoms, in
the same code. It was a lot easier to debug and the reasoning should
hopefully be easier to follow, but I don't think it was reviewed much
during the first posting due to the nightmare in the first patch.

Thanks,

Logan

[1] https://lore.kernel.org/lkml/de3e34d8-2ac3-e89b-30f1-a18826ce5d7d@deltatee.com/T/#m96ba95de4678146ed46b602e8bfd6ac08a588fa2

--

Changes in v3:

* Rebased onto v5.2-rc2 (no changes)

Changes in v2:

* Rebased onto v5.1-rc6 (no changes)
* Reworked the commit message in the first commit to try and explain
  it better.

--

Logan Gunthorpe (2):
  PCI: Prevent 64-bit resources from being counted in 32-bit bridge
    region
  PCI: Fix disabling of bridge BARs when assigning bus resources

 drivers/pci/setup-bus.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

--
2.20.1

Comments

Bjorn Helgaas June 17, 2019, 1:49 p.m. UTC | #1
[+cc Ben, Nicholas]

On Fri, May 31, 2019 at 11:12:14AM -0600, Logan Gunthorpe wrote:
> Hey,
> 
> This is another resend to get some more attention. Nothing has changed
> since v2.
> 
> For the first patch, there's a lot more information in the original
> thread here[1] including instructions on how to reproduce it in QEMU.
> 
> The second patch fixes an unrelated bug, with similar symptoms, in
> the same code. It was a lot easier to debug and the reasoning should
> hopefully be easier to follow, but I don't think it was reviewed much
> during the first posting due to the nightmare in the first patch.
> 
> Thanks,
> 
> Logan
> 
> [1] https://lore.kernel.org/lkml/de3e34d8-2ac3-e89b-30f1-a18826ce5d7d@deltatee.com/T/#m96ba95de4678146ed46b602e8bfd6ac08a588fa2
> 
> --
> 
> Changes in v3:
> 
> * Rebased onto v5.2-rc2 (no changes)
> 
> Changes in v2:
> 
> * Rebased onto v5.1-rc6 (no changes)
> * Reworked the commit message in the first commit to try and explain
>   it better.
> 
> --
> 
> Logan Gunthorpe (2):
>   PCI: Prevent 64-bit resources from being counted in 32-bit bridge
>     region
>   PCI: Fix disabling of bridge BARs when assigning bus resources
> 
>  drivers/pci/setup-bus.c | 24 ++++++++++++++----------
>  1 file changed, 14 insertions(+), 10 deletions(-)
> 
> --
> 2.20.1