[0/3] PCI/ASPM: add sysfs attribute for controlling ASPM
mbox series

Message ID 7a6d2f14-f2a6-99ad-3a93-fdaa0726ce86@gmail.com
Headers show
Series
  • PCI/ASPM: add sysfs attribute for controlling ASPM
Related show

Message

Heiner Kallweit May 23, 2019, 8:03 p.m. UTC
Background of this extension is a problem with the r8169 network driver.
Several combinations of board chipsets and network chip versions have
problems if ASPM is enabled, therefore we have to disable ASPM per
default. However especially on notebooks ASPM can provide significant
power-saving, therefore we want to give users the option to enable
ASPM. With the new sysfs attribute users can control which ASPM
link-states are disabled.

After few RFC's this is the submission-ready version. Added to the RFC
version has been documentation of the new sysfs attribute.

Heiner Kallweit (3):
  PCI/ASPM: add L1 sub-state support to pci_disable_link_state
  PCI/ASPM: allow to re-enable Clock PM
  PCI/ASPM: add sysfs attribute for controlling ASPM

 Documentation/ABI/testing/sysfs-bus-pci |  13 ++
 drivers/pci/pci.h                       |   8 +-
 drivers/pci/pcie/aspm.c                 | 211 ++++++++++++++++++++++--
 include/linux/pci-aspm.h                |   8 +-
 4 files changed, 219 insertions(+), 21 deletions(-)

Comments

Heiner Kallweit July 1, 2019, 8:07 p.m. UTC | #1
On 23.05.2019 22:03, Heiner Kallweit wrote:
> Background of this extension is a problem with the r8169 network driver.
> Several combinations of board chipsets and network chip versions have
> problems if ASPM is enabled, therefore we have to disable ASPM per
> default. However especially on notebooks ASPM can provide significant
> power-saving, therefore we want to give users the option to enable
> ASPM. With the new sysfs attribute users can control which ASPM
> link-states are disabled.
> 
> After few RFC's this is the submission-ready version. Added to the RFC
> version has been documentation of the new sysfs attribute.
> 
> Heiner Kallweit (3):
>   PCI/ASPM: add L1 sub-state support to pci_disable_link_state
>   PCI/ASPM: allow to re-enable Clock PM
>   PCI/ASPM: add sysfs attribute for controlling ASPM
> 
>  Documentation/ABI/testing/sysfs-bus-pci |  13 ++
>  drivers/pci/pci.h                       |   8 +-
>  drivers/pci/pcie/aspm.c                 | 211 ++++++++++++++++++++++--
>  include/linux/pci-aspm.h                |   8 +-
>  4 files changed, 219 insertions(+), 21 deletions(-)
> 
Can we get this into 5.3? The series was reviewed before in RFC state and
there have been no change requests.

Thanks, Heiner
AceLan Kao July 10, 2019, 6:59 a.m. UTC | #2
These patches work as expected and provide an interface to toggle PCI ASPM
link state, that's really helpful for PCI devices to check its ASPM
functionality by enabling/disabling it runtime.

Tested-by: AceLan Kao <acelan.kao@canonical.com>