mbox series

[v2,00/16] Improvements to trace buffers

Message ID 20190401234327.26819-1-jniethe5@gmail.com
Headers show
Series Improvements to trace buffers | expand

Message

Jordan Niethe April 1, 2019, 11:43 p.m. UTC 
The skiboot tracing faculties are not being used to their full extent
currently, despite the potential to be very useful. In this series
Patches 01-05 fix various bugs. Patches 06-16 aim to improve the
functionality of the dump_trace tool. This is done by setting up the
trace buffers to be mmaped, so the existing functions for reading trace
can be used by dump_trace. This provides numerous advantages over the
lseek/write method currently used, including handling overflow and
wrapping in the buffer. Support is also added to dump multiple traces at
the same time and a 'follow' option like 'tail -f' is added.

Comments

Russell Currey April 2, 2019, 2:27 a.m. UTC | #1 
Patches 8, 9, 11, 12 and 16 are missing Signed-off-by :)

(as pointed out by snowpatch)

So I just tested this and you can add -s (or --signoff) to git format-
patch and git send-email even if you forget to do it on commit, and if
you're sending a series it won't double-up signoffs on commits that do
already have it.
Stewart Smith May 21, 2019, 3:04 a.m. UTC | #2 
Russell Currey <ruscur@russell.cc> writes:
> Patches 8, 9, 11, 12 and 16 are missing Signed-off-by :)
>
> (as pointed out by snowpatch)

It seems to be a quirk of adding the v2 log before the signed-off-by
line, so I fixed it as I merged things in.

Series merged to master as of e0ed7e9985b49a3c9a2eac4c713aee1d441d5f47