mbox series

[ovs-dev,V4,0/3] Include libverbs and libmlx4/5 when needed

Message ID 20190211113108.31598-1-elibr@mellanox.com
Headers show
Series Include libverbs and libmlx4/5 when needed | expand

Message

Eli Britstein Feb. 11, 2019, 11:31 a.m. UTC 
This patch set automatically links with the necessary libraries for
MLX4/5 DPDK PMDs.

Patch 1 automatically links with the necessary libraries for MLX5 PMD

Patch 2 automatically links with the necessary libraries for MLX4 PMD

Patch 3 removes unnecessary define previously done for automatically link libmnl

Eli Britstein (3):
  acinclude: Include libverbs and libmlx5 when needed
  acinclude: Include libverbs and libmlx4 when needed
  acinclude: Omit unnecessary define

 acinclude.m4 | 39 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

Comments

Eli Britstein Feb. 17, 2019, 12:07 p.m. UTC | #1 
ping

On 2/11/2019 1:31 PM, Eli Britstein wrote:
> This patch set automatically links with the necessary libraries for
> MLX4/5 DPDK PMDs.
>
> Patch 1 automatically links with the necessary libraries for MLX5 PMD
>
> Patch 2 automatically links with the necessary libraries for MLX4 PMD
>
> Patch 3 removes unnecessary define previously done for automatically link libmnl
>
> Eli Britstein (3):
>    acinclude: Include libverbs and libmlx5 when needed
>    acinclude: Include libverbs and libmlx4 when needed
>    acinclude: Omit unnecessary define
>
>   acinclude.m4 | 39 +++++++++++++++++++++++++++++++++++++--
>   1 file changed, 37 insertions(+), 2 deletions(-)
>
Ilya Maximets Feb. 18, 2019, 3:41 p.m. UTC | #2 
I didn't try to build with mlx libs because I have no right
environment. But the code looks good to me.

For the series:
Acked-by: Ilya Maximets <i.maximets@samsung.com>

On 11.02.2019 14:31, Eli Britstein wrote:
> This patch set automatically links with the necessary libraries for
> MLX4/5 DPDK PMDs.
> 
> Patch 1 automatically links with the necessary libraries for MLX5 PMD
> 
> Patch 2 automatically links with the necessary libraries for MLX4 PMD
> 
> Patch 3 removes unnecessary define previously done for automatically link libmnl
> 
> Eli Britstein (3):
>   acinclude: Include libverbs and libmlx5 when needed
>   acinclude: Include libverbs and libmlx4 when needed
>   acinclude: Omit unnecessary define
> 
>  acinclude.m4 | 39 +++++++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
>
Stokes, Ian Feb. 18, 2019, 4:35 p.m. UTC | #3 
On 2/18/2019 3:41 PM, Ilya Maximets wrote:
> I didn't try to build with mlx libs because I have no right
> environment. But the code looks good to me.
> 
> For the series:
> Acked-by: Ilya Maximets <i.maximets@samsung.com>

Thanks for series, pushed to master and 2.11.

Ian